[GitHub] [iceberg] rdblue commented on a change in pull request #1455: Hive3/Hadoop3 upgrade for iceberg-mr and iceberg-flink - [Draft]

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1455:
URL: https://github.com/apache/iceberg/pull/1455#discussion_r488070268



##########
File path: mr/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergDateObjectInspector.java
##########
@@ -42,17 +42,17 @@ private IcebergDateObjectInspector() {
 
   @Override
   public Date getPrimitiveJavaObject(Object o) {
-    return o == null ? null : Date.valueOf((LocalDate) o);
+    return o == null ? null : Date.valueOf(o.toString());

Review comment:
       Date/time values must be converted directly and not via string. Conversions like this will lead to time zone bugs.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org