You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/22 18:02:48 UTC
[GitHub] [airflow] Dr-Denzy opened a new issue, #25240: Strip white spaces from values entered into fields in Airflow UI Connections form
Dr-Denzy opened a new issue, #25240:
URL: https://github.com/apache/airflow/issues/25240
### Apache Airflow version
2.3.3 (latest released)
### What happened
I accidentally (and then intentionally) added leading and trailing white spaces while adding connection parameters in Airflow UI Connections form. What followed was an error message that was not so helpful in tracking down the input error by the user.
### What you think should happen instead
Ideally, I expected that there should be a frontend or backend logic that strips off accidental leading or trailing white spaces when adding Connections parameters in Airflow.
### How to reproduce
Intentionally add leading or trailing white spaces while adding Connections parameters.
<img width="981" alt="Screenshot 2022-07-22 at 18 49 54" src="https://user-images.githubusercontent.com/9834450/180497315-0898d803-c104-4d93-b464-c0b33a466b4d.png">
### Operating System
Mac OS
### Versions of Apache Airflow Providers
_No response_
### Deployment
Virtualenv installation
### Deployment details
_No response_
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #25240: Strip white spaces from values entered into fields in Airflow UI Connections form
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #25240:
URL: https://github.com/apache/airflow/issues/25240#issuecomment-1614612497
It's a UI things. I keep a bit away from that - it looks like some javascript update and needs understanding how FAB connection view form maps into the UI - that's basically the starting point. When I did work there I was just running it locally and debugging what's going on when I opened the form - seeing what was produced on the web/javascript page - more discovery than knowledge. And I forgot all that I learned then since :). Long time ago.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala closed issue #25240: Strip white spaces from values entered into fields in Airflow UI Connections form
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala closed issue #25240: Strip white spaces from values entered into fields in Airflow UI Connections form
URL: https://github.com/apache/airflow/issues/25240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #25240: Strip white spaces from values entered into fields in Airflow UI Connections form
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #25240:
URL: https://github.com/apache/airflow/issues/25240#issuecomment-1614568271
@Dr-Denzy @potiuk I would like to take this up. Any starting point here would be nice :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #25240: Strip white spaces from values entered into fields in Airflow UI Connections form
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #25240:
URL: https://github.com/apache/airflow/issues/25240#issuecomment-1192943855
Feel free to add a PR. Assigned you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #25240: Strip white spaces from values entered into fields in Airflow UI Connections form
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #25240:
URL: https://github.com/apache/airflow/issues/25240#issuecomment-1614768222
Haha makes sense! :)
I think it should be a backend strip rather than making the changes to the UI code..but that is just a way of coding it out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org