[jira] [Commented] (PROTON-2322) Fix and remove ignores in flake8 configuration

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286551#comment-17286551 ] 

ASF GitHub Bot commented on PROTON-2322:
----------------------------------------

jiridanek commented on a change in pull request #289:
URL: https://github.com/apache/qpid-proton/pull/289#discussion_r578524266



##########
File path: python/tox.ini
##########
@@ -25,6 +25,33 @@ deps =
 changedir = {[tox]setupdir}
 commands = flake8
 
+[flake8]
+# TODO(PROTON-2322) decrease the limit
+max-line-length = 150
+
+# TODO(PROTON-2322) re-enable all these warnings
+ignore =
+    # do not use bare 'except'
+    E722,
+    # imported but unused
+    F401,
+    # 'from proton import *' used; unable to detect undefined names
+    F403,

Review comment:
       https://issues.apache.org/jira/browse/PROTON-2336




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix and remove ignores in flake8 configuration
> ----------------------------------------------
>
>                 Key: PROTON-2322
>                 URL: https://issues.apache.org/jira/browse/PROTON-2322
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: python-binding
>    Affects Versions: proton-c-0.34.0
>            Reporter: Jiri Daněk
>            Priority: Major
>
> Fixes with autopep8 in PROTON-2320 resolved most of flake8 warnings. There are still warnings left that require human consideration and fixing.
> For example, usage of bare {{except}} in the code.
> This must be fixed manually. Fixed issues should then be removed from the tox.ini flake8 ignore section.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org