You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by "huage1994 (via GitHub)" <gi...@apache.org> on 2023/03/01 03:56:34 UTC

[GitHub] [zeppelin] huage1994 commented on pull request #4559: [ZEPPELIN-5879] Migrate Zeppelin Plugins to JUnit5

huage1994 commented on PR #4559:
URL: https://github.com/apache/zeppelin/pull/4559#issuecomment-1449293326

   Hi @Reamer ,  this PR is a great job.  It all looks good to me.  
   I just have a very small question about this:  I noticed that you removed the `public`  modifier from the `@Test` method but retain the `public` modifier for methods that are decorated by `@BeforEeach` .
   
   Is there any special purpose in this?  I've tried to remove `public` modifier for `@BeforEeach` methods , it looks ok.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org