You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org> on 2020/03/18 23:08:30 UTC

[kudu-CR] [client] Mark the Bloom filter predicate method as experimental

Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15486


Change subject: [client] Mark the Bloom filter predicate method as experimental
......................................................................

[client] Mark the Bloom filter predicate method as experimental

This is the method meant for general consumption by C++ client
users. The method that directly accepts BlockBloomFilter
is already marked Advanced/Unstable.

This allows changes in future in case we need to incorporate
feedback discovered when testing integration with Impala

Tests:
- Verified the generated doxygen HTML file.

Change-Id: Ie1572228dc041d2e5cba68ee47afbb082752b759
---
M src/kudu/client/client.h
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/15486/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1572228dc041d2e5cba68ee47afbb082752b759
Gerrit-Change-Number: 15486
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>

[kudu-CR] [client] Mark the Bloom filter predicate method as experimental

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15486 )

Change subject: [client] Mark the Bloom filter predicate method as experimental
......................................................................

[client] Mark the Bloom filter predicate method as experimental

This is the method meant for general consumption by C++ client
users. The method that directly accepts BlockBloomFilter
is already marked Advanced/Unstable.

This allows changes in future in case we need to incorporate
feedback discovered when testing integration with Impala

Tests:
- Verified the generated doxygen HTML file.

Change-Id: Ie1572228dc041d2e5cba68ee47afbb082752b759
Reviewed-on: http://gerrit.cloudera.org:8080/15486
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/client/client.h
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1572228dc041d2e5cba68ee47afbb082752b759
Gerrit-Change-Number: 15486
Gerrit-PatchSet: 2
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [client] Mark the Bloom filter predicate method as experimental

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15486 )

Change subject: [client] Mark the Bloom filter predicate method as experimental
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1572228dc041d2e5cba68ee47afbb082752b759
Gerrit-Change-Number: 15486
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Mar 2020 23:15:48 +0000
Gerrit-HasComments: No