You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Jacques Le Roux (JIRA)" <ji...@apache.org> on 2008/02/23 15:05:19 UTC

[jira] Issue Comment Edited: (OFBIZ-1663) POS: All payment types allow change to be made

    [ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571742#action_12571742 ] 

jacques.le.roux edited comment on OFBIZ-1663 at 2/23/08 6:03 AM:
-----------------------------------------------------------------

Hi Chris,

I commited a slightly modified (i10n) version of your patch in trunk revision: 630437  and release4.0 630438

But I do not close this issue since I got the error below while trying to pay 1st with cash and then with a check. Not sure it's related. I have no more time now so feel free to close this issue and open a new one if you think it's needed. Thanks

2008-02-23 14:56:32,906 (Thread-89) [          PosButton.java:125:ERROR]
---- exception report ----------------------------------------------------------
Button invocation exception - ALT.payFinish
Exception: org.ofbiz.pos.config.ButtonEventConfig$ButtonEventException
Message: null
---- stack trace ---------------------------------------------------------------
org.ofbiz.pos.config.ButtonEventConfig$ButtonEventException
org.ofbiz.pos.config.ButtonEventConfig.invoke(ButtonEventConfig.java:216)
org.ofbiz.pos.config.ButtonEventConfig.invokeButtonEvent(ButtonEventConfig.java:105)
org.ofbiz.pos.component.PosButton$1.construct(PosButton.java:121)
net.xoetrope.xui.helper.SwingWorker$2.run(Unknown Source)
java.lang.Thread.run(Thread.java:595)
java.lang.reflect.InvocationTargetException
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
java.lang.reflect.Method.invoke(Method.java:585)
org.ofbiz.pos.config.ButtonEventConfig.invoke(ButtonEventConfig.java:208)
org.ofbiz.pos.config.ButtonEventConfig.invokeButtonEvent(ButtonEventConfig.java:105)
org.ofbiz.pos.component.PosButton$1.construct(PosButton.java:121)
net.xoetrope.xui.helper.SwingWorker$2.run(Unknown Source)
java.lang.Thread.run(Thread.java:595)
Caused by: org.ofbiz.base.util.GeneralRuntimeException: Split Payment Preference per Ship Group does not yet support multiple Payment Methods
org.ofbiz.order.shoppingcart.ShoppingCart$CartPaymentInfo.makeOrderPaymentInfos(ShoppingCart.java:4527)
org.ofbiz.order.shoppingcart.ShoppingCart.makeAllOrderPaymentInfos(ShoppingCart.java:3588)
org.ofbiz.order.shoppingcart.ShoppingCart.makeCartMap(ShoppingCart.java:3825)
org.ofbiz.order.shoppingcart.CheckOutHelper.createOrder(CheckOutHelper.java:572)
org.ofbiz.order.shoppingcart.CheckOutHelper.createOrder(CheckOutHelper.java:545)
org.ofbiz.pos.PosTransaction.processSale(PosTransaction.java:763)
org.ofbiz.pos.event.PaymentEvents.processSale(PaymentEvents.java:306)
        ... 9 more
--------------------------------------------------------------------------------


      was (Author: jacques.le.roux):
    Hi Chris,

I commited a slightly modified (i10n) version of your patch in trunk revision: 630437  and release4.0

But I do not close this issue since I got the error below while trying to pay 1st with cash and then with a check. Not sure it's related. I have no more time now so feel free to close this issue and open a new one if you think it's needed. Thanks

2008-02-23 14:56:32,906 (Thread-89) [          PosButton.java:125:ERROR]
---- exception report ----------------------------------------------------------
Button invocation exception - ALT.payFinish
Exception: org.ofbiz.pos.config.ButtonEventConfig$ButtonEventException
Message: null
---- stack trace ---------------------------------------------------------------
org.ofbiz.pos.config.ButtonEventConfig$ButtonEventException
org.ofbiz.pos.config.ButtonEventConfig.invoke(ButtonEventConfig.java:216)
org.ofbiz.pos.config.ButtonEventConfig.invokeButtonEvent(ButtonEventConfig.java:105)
org.ofbiz.pos.component.PosButton$1.construct(PosButton.java:121)
net.xoetrope.xui.helper.SwingWorker$2.run(Unknown Source)
java.lang.Thread.run(Thread.java:595)
java.lang.reflect.InvocationTargetException
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
java.lang.reflect.Method.invoke(Method.java:585)
org.ofbiz.pos.config.ButtonEventConfig.invoke(ButtonEventConfig.java:208)
org.ofbiz.pos.config.ButtonEventConfig.invokeButtonEvent(ButtonEventConfig.java:105)
org.ofbiz.pos.component.PosButton$1.construct(PosButton.java:121)
net.xoetrope.xui.helper.SwingWorker$2.run(Unknown Source)
java.lang.Thread.run(Thread.java:595)
Caused by: org.ofbiz.base.util.GeneralRuntimeException: Split Payment Preference per Ship Group does not yet support multiple Payment Methods
org.ofbiz.order.shoppingcart.ShoppingCart$CartPaymentInfo.makeOrderPaymentInfos(ShoppingCart.java:4527)
org.ofbiz.order.shoppingcart.ShoppingCart.makeAllOrderPaymentInfos(ShoppingCart.java:3588)
org.ofbiz.order.shoppingcart.ShoppingCart.makeCartMap(ShoppingCart.java:3825)
org.ofbiz.order.shoppingcart.CheckOutHelper.createOrder(CheckOutHelper.java:572)
org.ofbiz.order.shoppingcart.CheckOutHelper.createOrder(CheckOutHelper.java:545)
org.ofbiz.pos.PosTransaction.processSale(PosTransaction.java:763)
org.ofbiz.pos.event.PaymentEvents.processSale(PaymentEvents.java:306)
        ... 9 more
--------------------------------------------------------------------------------

  
>  POS:  All payment types allow change to be made
> ------------------------------------------------
>
>                 Key: OFBIZ-1663
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1663
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/pos
>    Affects Versions: Release Branch 4.0
>            Reporter: Chris Lombardi
>            Priority: Minor
>         Attachments: ofbiz-1663.patch
>
>
> I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
> I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given.  This would apply for both cash sales and multiple payment type sales.
> Does anyone have any international scenarios that would not follow this rule?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.