You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/01/02 19:22:09 UTC

[GitHub] [hbase] saintstack commented on a change in pull request #2815: HBASE-24751 Display Task completion time and/or processing duration o…

saintstack commented on a change in pull request #2815:
URL: https://github.com/apache/hbase/pull/2815#discussion_r550912266



##########
File path: hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/common/TaskMonitorTmpl.jamon
##########
@@ -116,6 +117,7 @@ String parent = "";
                       <td><% task.getStatus() %>
                           (since <% StringUtils.formatTimeDiff(now, task.getStatusTime()) %>
                           ago)</td>
+                      <td><% task.getCompletionTimestamp() < 0 ? task.getState() : new Date(task.getCompletionTimestamp()) %></td>

Review comment:
       I think duration would be a nice-to-have. Can add in a follow-on. This is already a nice improvement as is. Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org