You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by il...@apache.org on 2018/10/31 03:30:00 UTC
[incubator-dubbo] branch master updated: replace
ServiceAnnotationBeanPostProcessor log.isInfoEnabled->log.isWarnEnabled
(#2712)
This is an automated email from the ASF dual-hosted git repository.
iluo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo.git
The following commit(s) were added to refs/heads/master by this push:
new c21cc05 replace ServiceAnnotationBeanPostProcessor log.isInfoEnabled->log.isWarnEnabled (#2712)
c21cc05 is described below
commit c21cc05ec9ff4f96f34af9027714bb525cd0edf5
Author: vkeeper <vr...@vip.qq.com>
AuthorDate: Wed Oct 31 11:29:54 2018 +0800
replace ServiceAnnotationBeanPostProcessor log.isInfoEnabled->log.isWarnEnabled (#2712)
simplify ExtensionLoader code segment
---
.../apache/dubbo/common/extension/ExtensionLoader.java | 15 ++-------------
.../annotation/ServiceAnnotationBeanPostProcessor.java | 2 +-
2 files changed, 3 insertions(+), 14 deletions(-)
diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java b/dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java
index 75b7562..1d071a1 100644
--- a/dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java
+++ b/dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java
@@ -860,19 +860,8 @@ public class ExtensionLoader<T> {
String[] value = adaptiveAnnotation.value();
// value is not set, use the value generated from class name as the key
if (value.length == 0) {
- char[] charArray = type.getSimpleName().toCharArray();
- StringBuilder sb = new StringBuilder(128);
- for (int i = 0; i < charArray.length; i++) {
- if (Character.isUpperCase(charArray[i])) {
- if (i != 0) {
- sb.append(".");
- }
- sb.append(Character.toLowerCase(charArray[i]));
- } else {
- sb.append(charArray[i]);
- }
- }
- value = new String[]{sb.toString()};
+ String splitName = StringUtils.camelToSplitName(type.getSimpleName(), ".");
+ value = new String[]{splitName};
}
boolean hasInvocation = false;
diff --git a/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/beans/factory/annotation/ServiceAnnotationBeanPostProcessor.java b/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/beans/factory/annotation/ServiceAnnotationBeanPostProcessor.java
index 389ef21..0558528 100644
--- a/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/beans/factory/annotation/ServiceAnnotationBeanPostProcessor.java
+++ b/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/beans/factory/annotation/ServiceAnnotationBeanPostProcessor.java
@@ -261,7 +261,7 @@ public class ServiceAnnotationBeanPostProcessor implements BeanDefinitionRegistr
if (scanner.checkCandidate(beanName, serviceBeanDefinition)) { // check duplicated candidate bean
registry.registerBeanDefinition(beanName, serviceBeanDefinition);
- if (logger.isInfoEnabled()) {
+ if (logger.isWarnEnabled()) {
logger.warn("The BeanDefinition[" + serviceBeanDefinition +
"] of ServiceBean has been registered with name : " + beanName);
}