You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/06/20 22:20:00 UTC
[GitHub] [activemq-artemis] Havret opened a new pull request #3195: ARTEMIS-2815: Fix null pointer exception on attempt to update queue without filter
Havret opened a new pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195
I'm not sure if there more elegant way to do it in Java. Any hints would be greatly appreciated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelpearce-gain edited a comment on pull request #3195: ARTEMIS-2815 Fix null pointer exception on attempt to update queue without filter
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain edited a comment on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647366360
> BTW, what's about with this -->
>
> https://github.com/apache/activemq-artemis/blob/4e77a9fb79503af017695c0955438517450c0d50/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java#L3965-L3966
This is because the QueueImpl doesnt support LVQ, theres a special extended version, as such its not possible atm to update (you have to remove and re add a queue currently) This is something though that could be rolled into a single queue, and make it updateable, i had a poc a while back, just never got time to finish it. And no one is shouting for it so like all things prioritised down.
I can re-pick it up, if you have a need to switch from LVQ to normal queue and back, without distruction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelpearce-gain edited a comment on pull request #3195: ARTEMIS-2815 Fix null pointer exception on attempt to update queue without filter
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain edited a comment on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647366360
> BTW, what's about with this -->
>
> https://github.com/apache/activemq-artemis/blob/4e77a9fb79503af017695c0955438517450c0d50/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java#L3965-L3966
This is because the QueueImpl doesnt support LVQ (theres a special extended version, as such its not possible atm to update (you have to remove and re add a queue currently) This is something though that could be rolled into a single queue, and make it updateable, i had a poc a while back, just never got time to finish it. And no one is shouting for it so like all things prioritised down.
I can re-pick it up, if you have a need to switch from LVQ to normal queue and back, without distruction.
In particular to the setLastValue(null), that should be setLastValueKey(null) thats just a mistake in the move to queueConfig recently, feel free to fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on pull request #3195: ARTEMIS-2815 Fix null pointer exception on attempt to update queue without filter
Posted by GitBox <gi...@apache.org>.
brusdev commented on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647364727
@Havret I guess the second one should be .setLastValueKey(null). @jbertram WDYT?
> BTW, what's about with this -->
>
> https://github.com/apache/activemq-artemis/blob/4e77a9fb79503af017695c0955438517450c0d50/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java#L3965-L3966
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelpearce-gain edited a comment on pull request #3195: ARTEMIS-2815 Fix null pointer exception on attempt to update queue without filter
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain edited a comment on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647366360
> BTW, what's about with this -->
>
> https://github.com/apache/activemq-artemis/blob/4e77a9fb79503af017695c0955438517450c0d50/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java#L3965-L3966
These are hard coded, because the QueueImpl doesnt support LVQ (theres a special extended version, as such its not possible atm to update (you have to remove and re add a queue currently) This is something though that could be rolled into a single queue, and make it updateable, i had a poc a while back, just never got time to finish it. And no one is shouting for it so like all things prioritised down.
I can re-pick it up, if you have a need to switch from LVQ to normal queue and back, without distruction.
In particular to the setLastValue(null), that should be setLastValueKey(null) thats just a mistake in the move to queueConfig recently, feel free to fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelpearce-gain commented on pull request #3195: ARTEMIS-2815 Fix null pointer exception on attempt to update queue without filter
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain commented on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647366360
> BTW, what's about with this -->
>
> https://github.com/apache/activemq-artemis/blob/4e77a9fb79503af017695c0955438517450c0d50/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java#L3965-L3966
This is because the QueueImpl doesnt support LVQ, theres a special extended version, as such its not possible atm to update (you have to remove and re add a queue currently) This is something though that could be rolled into a single queue, and make it updateable, i had a poc a while back, just never got time to finish it. And no one is shouting for it so like all things prioritised down.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] Havret commented on pull request #3195: ARTEMIS-2815 Fix null pointer exception on attempt to update queue without filter
Posted by GitBox <gi...@apache.org>.
Havret commented on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647093196
BTW, what's about with this --> https://github.com/apache/activemq-artemis/blob/4e77a9fb79503af017695c0955438517450c0d50/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java#L3965-L3966
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3195: ARTEMIS-2815 Fix null pointer exception on attempt to update queue without filter
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647841459
@michaelandrepearce cool.. I will start the release tomorrow. I will wait a final review from you tomorrow, or if you don't merge it by then I will do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3195: ARTEMIS-2815 Fix null pointer exception on attempt to update queue without filter
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647527301
LGTM...
@michaelandrepearce I'm not merging this as I'm not sure if you settled your discussion here. if you could merge when done please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on pull request #3195: ARTEMIS-2815 Fix null pointer exception on attempt to update queue without filter
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647084241
You can inline it by
filter == null ? null : filter.getFilterString():
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] Havret commented on pull request #3195: ARTEMIS-2815 Fix null pointer exception on attempt to update queue without filter
Posted by GitBox <gi...@apache.org>.
Havret commented on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647089134
Thanks Mike, fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] Havret commented on pull request #3195: ARTEMIS-2815 Fix null pointer exception on attempt to update queue without filter
Posted by GitBox <gi...@apache.org>.
Havret commented on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647772843
@michaelandrepearce @clebertsuconic I've pushed the changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3195: ARTEMIS-2815 Fix null pointer exception on attempt to update queue without filter
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3195: ARTEMIS-2815 Fix null pointer exception on attempt to update queue without filter
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647084241
You can inline it by filter == null ? null : filter.getFilterString():
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelpearce-gain commented on pull request #3195: ARTEMIS-2815 Fix null pointer exception on attempt to update queue without filter
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain commented on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647997888
@Havret merged thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on pull request #3195: ARTEMIS-2815 Fix null pointer exception on attempt to update queue without filter
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647084241
You can do it simpler with
filter == null ? null : filter.getFilterString():
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelpearce-gain commented on pull request #3195: ARTEMIS-2815 Fix null pointer exception on attempt to update queue without filter
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain commented on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647533882
@clebertsuconic setLastValueKey needs to be fixed, I believe @Havret is looking to push a fix on that tonight or tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org