You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2016/07/15 06:23:11 UTC
[GitHub] zeppelin pull request #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should n...
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/1189
ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ZEPPELIN_JAVA_OPTS
### What is this PR for?
Don't use ZEPPELIN_JAVA_OPTS as the default value of ZEPPELIN_INTP_JAVA_OPTS
### What type of PR is it?
Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1185
### How should this be tested?
Tested manually.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/incubator-zeppelin ZEPPELIN-1185
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1189.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1189
----
commit a54d843979a7a7c843394d56b1678c0380ffa048
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-07-15T06:21:21Z
ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ZEPPELIN_JAVA_OPTS as default value
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should n...
Posted by zjffdu <gi...@git.apache.org>.
GitHub user zjffdu reopened a pull request:
https://github.com/apache/zeppelin/pull/1189
ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ZEPPELIN_JAVA_OPTS
### What is this PR for?
Don't use ZEPPELIN_JAVA_OPTS as the default value of ZEPPELIN_INTP_JAVA_OPTS
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1185
### How should this be tested?
Tested manually. By exporting the following variable, I can debug zeppelin server correctly and remote interpreter process can ran successfully. (Before this PR, the remote interpreter process will fail to launch because it would also listen the same debug port)
```
export ZEPPELIN_JAVA_OPTS="-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005"
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1185
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1189.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1189
----
commit ef5a36097e0b43bb08b0e4a3659e41d849039f34
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-07-15T06:21:21Z
ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ZEPPELIN_JAVA_OPTS as default value
commit e82d88986e2ff7cddec0cb2c28f0f874dd07ad83
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-07-26T01:14:24Z
add migration doc
commit 3ff5561e4fde109e40e28faee41711e960803586
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-07-26T03:07:49Z
update doc format
commit 9e48ad75c64b1efa4ad310e44dbfa48e225efab0
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-08-04T10:16:56Z
change for windows
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1189
Thanks @AhyoungRyu , I have updated the doc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1189
Thanks for contribution!
`ZEPPELIN_JAVA_OPTS` used to set JVM options both ZeppelinServer and InterpreterProcess.
Later `ZEPPELIN_INTP_JAVA_OPTS` has been introduced. To keep compatibility with previous configuration, `ZEPPELIN_INTP_JAVA_OPTS` designed to overrides `ZEPPELIN_JAVA_OPTS` for InterpreterProcess.
So previous version of `conf/zeppelin-env.sh` can work without modification.
That's why InterpreterProcess looks like implicitly uses `ZEPPELIN_JAVA_OPTS`.
I don't have any preference of either keeping current behavior or change it.
But if you'd like to change, I think `ZEPPELIN_INTP_MEM` also need to be changed, to make configuration consistent.
Also, this change makes `conf/zeppelin-env.sh` incompatible to previous version. So i think it's great idea that guide user how `ZEPPELIN_JAVA_OPTS` and `ZEPPELIN_INTP_JAVA_OPTS` are changed through https://github.com/apache/zeppelin/blob/master/docs/install/upgrade.md.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should n...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu closed the pull request at:
https://github.com/apache/zeppelin/pull/1189
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should n...
Posted by zjffdu <gi...@git.apache.org>.
GitHub user zjffdu reopened a pull request:
https://github.com/apache/zeppelin/pull/1189
ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ZEPPELIN_JAVA_OPTS
### What is this PR for?
Don't use ZEPPELIN_JAVA_OPTS as the default value of ZEPPELIN_INTP_JAVA_OPTS
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1185
### How should this be tested?
Tested manually. By exporting the following variable, I can debug zeppelin server correctly and remote interpreter process can ran successfully. (Before this PR, the remote interpreter process will fail to launch because it would also listen the same debug port)
```
export ZEPPELIN_JAVA_OPTS="-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005"
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1185
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1189.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1189
----
commit ef5a36097e0b43bb08b0e4a3659e41d849039f34
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-07-15T06:21:21Z
ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ZEPPELIN_JAVA_OPTS as default value
commit e82d88986e2ff7cddec0cb2c28f0f874dd07ad83
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-07-26T01:14:24Z
add migration doc
commit 3ff5561e4fde109e40e28faee41711e960803586
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-07-26T03:07:49Z
update doc format
commit 9e48ad75c64b1efa4ad310e44dbfa48e225efab0
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-08-04T10:16:56Z
change for windows
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1189
@Leemoonsoo I pushed another commit to add migration section in upgrade.md, please help review. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1189
BTW, I will do the windows related change after we make consensus on this approach.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should n...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1189
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1189
Change looks good.
Could you trigger CI once again and see if it becomes green?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should n...
Posted by zjffdu <gi...@git.apache.org>.
GitHub user zjffdu reopened a pull request:
https://github.com/apache/zeppelin/pull/1189
ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ZEPPELIN_JAVA_OPTS
### What is this PR for?
Don't use ZEPPELIN_JAVA_OPTS as the default value of ZEPPELIN_INTP_JAVA_OPTS
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1185
### How should this be tested?
Tested manually. By exporting the following variable, I can debug zeppelin server correctly and remote interpreter process can ran successfully. (Before this PR, the remote interpreter process will fail to launch because it would also listen the same debug port)
```
export ZEPPELIN_JAVA_OPTS="-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005"
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1185
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1189.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1189
----
commit ef5a36097e0b43bb08b0e4a3659e41d849039f34
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-07-15T06:21:21Z
ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ZEPPELIN_JAVA_OPTS as default value
commit e82d88986e2ff7cddec0cb2c28f0f874dd07ad83
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-07-26T01:14:24Z
add migration doc
commit 3ff5561e4fde109e40e28faee41711e960803586
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-07-26T03:07:49Z
update doc format
commit 9e48ad75c64b1efa4ad310e44dbfa48e225efab0
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-08-04T10:16:56Z
change for windows
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1189
I guess @khalidhuseynov did not mean to refer this PR, but just used short-cut to name the JIRA issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1189
Thanks @zjffdu.
LGTM and merge if there's no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should n...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu closed the pull request at:
https://github.com/apache/zeppelin/pull/1189
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1189
\\cc @Leemoonsoo Ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1189
I'll merge this in sometime soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1189
ping @Leemoonsoo in case you miss it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1189: ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should n...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu closed the pull request at:
https://github.com/apache/zeppelin/pull/1189
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---