[GitHub] [arrow] eitsupi commented on a change in pull request #12474: ARROW-15599: [R] Convert a column as a sub-second timestamp from CSV file with the `T` col type option

[GitBox <gi...@apache.org>]

eitsupi commented on a change in pull request #12474:
URL: https://github.com/apache/arrow/pull/12474#discussion_r815221124



##########
File path: r/R/csv.R
##########
@@ -61,8 +61,8 @@
 #' * "l": `bool()`
 #' * "f": `dictionary()`
 #' * "D": `date32()`
-#' * "T": `timestamp()`
-#' * "t": `time32()`
+#' * "T": `timestamp(unit = "ns")`
+#' * "t": `time32(unit = "ms")`

Review comment:
       This is the default value in the current implementation. However, I think it should be explicit because it is not explicit for users looking at the help page for this function.
   
   ``` r
   arrow::time32() == arrow::time32(unit = "ms")
   #> [1] TRUE
   arrow::time32() == arrow::time32(unit = "s")
   #> [1] FALSE
   ```
   
   <sup>Created on 2022-02-25 by the [reprex package](https://reprex.tidyverse.org) (v2.0.1)</sup>
   
   Even if it should not be changed in this PullRequest, it should be changed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org