You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/10/25 09:13:23 UTC

[GitHub] [incubator-kyuubi] zwangsheng opened a new pull request, #3691: [KYUUBI #3677][K8S] Bump Kubernetes Client Version to 6.1.1

zwangsheng opened a new pull request, #3691:
URL: https://github.com/apache/incubator-kyuubi/pull/3691

   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   Bump Kubernetes Client Version to 6.1.1.
   To keep up with https://github.com/apache/spark/pull/37990 dependence kubernetes client [changes](https://github.com/fabric8io/kubernetes-client/compare/v5.12.1...v6.1.1).
   
   Close #3677
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3691: [KYUUBI #3677][K8S] Bump Kubernetes Client Version to 6.1.1

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3691:
URL: https://github.com/apache/incubator-kyuubi/pull/3691#discussion_r1007763220


##########
pom.xml:
##########
@@ -613,6 +613,12 @@
                 <artifactId>kubernetes-client</artifactId>
                 <version>${kubernetes-client.version}</version>
             </dependency>
+            <!-- according to https://github.com/fabric8io/kubernetes-client/blob/master/doc/MIGRATION-v6.md#okhttp-httpclient -->

Review Comment:
   how about explain in this way: `According something, then we should do something balalah or maybe to avoid something`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] zwangsheng commented on pull request #3691: [KYUUBI #3677][K8S] Bump Kubernetes Client Version to 6.1.1

Posted by GitBox <gi...@apache.org>.
zwangsheng commented on PR #3691:
URL: https://github.com/apache/incubator-kyuubi/pull/3691#issuecomment-1298142234

   > @zwangsheng seems the failed tests is related ?
   
   ```log
   2/10/31 10:09:18 INFO DAGScheduler: Submitting ResultStage 0 (MapPartitionsRDD[2] at isEmpty at KyuubiSparkUtil.scala:48), which has no missing parents
   22/10/31 10:09:18 INFO MemoryStore: Block broadcast_0 stored as values in memory (estimated size 6.6 KiB, free 127.2 MiB)
   22/10/31 10:09:18 INFO MemoryStore: Block broadcast_0_piece0 stored as bytes in memory (estimated size 3.5 KiB, free 127.2 MiB)
   22/10/31 10:09:18 INFO BlockManagerInfo: Added broadcast_0_piece0 in memory on fv-az256-952:41265 (size: 3.5 KiB, free: 127.2 MiB)
   22/10/31 10:09:18 INFO SparkContext: Created broadcast 0 from broadcast at DAGScheduler.scala:1478
   22/10/31 10:09:18 INFO DAGScheduler: Submitting 1 missing tasks from ResultStage 0 (MapPartitionsRDD[2] at isEmpty at KyuubiSparkUtil.scala:48) (first 15 tasks are for partitions Vector(0))
   22/10/31 10:09:18 INFO TaskSchedulerImpl: Adding task set 0.0 with 1 tasks resource profile 0
   22/10/31 10:09:33 WARN TaskSchedulerImpl: Initial job has not accepted any resources; check your cluster UI to ensure that workers are registered and have sufficient resources
   22/10/31 10:09:48 WARN TaskSchedulerImpl: Initial job has not accepted any resources; check your cluster UI to ensure that workers are registered and have sufficient resources
   22/10/31 10:10:03 WARN TaskSchedulerImpl: Initial job has not accepted any resources; check your cluster UI to ensure that workers are registered and have sufficient resources
   22/10/31 10:10:18 WARN TaskSchedulerImpl: Initial job has not accepted any resources; check your cluster UI to ensure that workers are registered and have sufficient resources
   22/10/31 10:10:33 WARN TaskSchedulerImpl: Initial job has not accepted any resources; check your cluster UI to ensure that workers are registered and have sufficient resources
   22/10/31 10:10:48 WARN TaskSchedulerImpl: Initial job has not accepted any resources; check your cluster UI to ensure that workers are registered and have sufficient resources
   22/10/31 10:11:03 WARN TaskSchedulerImpl: Initial job has not accepted any resources; check your cluster UI to ensure that workers are registered and have sufficient resources
   22/10/31 10:11:18 WARN TaskSchedulerImpl: Initial job has not accepted any resources; check your cluster UI to ensure that workers are registered and have sufficient resources
   22/10/31 10:11:33 WARN TaskSchedulerImpl: Initial job has not accepted any resources; check your cluster UI to ensure that workers are registered and have sufficient resources
   22/10/31 10:11:37 ERROR SparkSQLEngine: The Engine main thread was interrupted, possibly due to `createSpark` timeout. The `kyuubi.session.engine.initialize.timeout` is (180000 ms)  and submitted at 1667210917099.
   java.lang.InterruptedException
   	at java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1040)
   	at java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1345)
   	at scala.concurrent.impl.Promise$DefaultPromise.tryAwait(Promise.scala:242)
   	at scala.concurrent.impl.Promise$DefaultPromise.ready(Promise.scala:258)
   	at scala.concurrent.impl.Promise$DefaultPromise.ready(Promise.scala:187)
   	at org.apache.spark.util.ThreadUtils$.awaitReady(ThreadUtils.scala:334)
   	at org.apache.spark.scheduler.DAGScheduler.runJob(DAGScheduler.scala:929)
   	at org.apache.spark.SparkContext.runJob(SparkContext.scala:2214)
   	at org.apache.spark.SparkContext.runJob(SparkContext.scala:2235)
   	at org.apache.spark.SparkContext.runJob(SparkContext.scala:2254)
   	at org.apache.spark.sql.execution.SparkPlan.executeTake(SparkPlan.scala:492)
   	at org.apache.spark.sql.execution.SparkPlan.executeTake(SparkPlan.scala:445)
   	at org.apache.spark.sql.Dataset.$anonfun$isEmpty$1(Dataset.scala:604)
   	at org.apache.spark.sql.Dataset.$anonfun$isEmpty$1$adapted(Dataset.scala:603)
   	at org.apache.spark.sql.Dataset.$anonfun$withAction$1(Dataset.scala:3706)
   	at org.apache.spark.sql.execution.SQLExecution$.$anonfun$withNewExecutionId$5(SQLExecution.scala:103)
   	at org.apache.spark.sql.execution.SQLExecution$.withSQLConfPropagated(SQLExecution.scala:163)
   	at org.apache.spark.sql.execution.SQLExecution$.$anonfun$withNewExecutionId$1(SQLExecution.scala:90)
   	at org.apache.spark.sql.SparkSession.withActive(SparkSession.scala:775)
   	at org.apache.spark.sql.execution.SQLExecution$.withNewExecutionId(SQLExecution.scala:64)
   	at org.apache.spark.sql.Dataset.withAction(Dataset.scala:3704)
   	at org.apache.spark.sql.Dataset.isEmpty(Dataset.scala:603)
   	at org.apache.kyuubi.engine.spark.KyuubiSparkUtil$.$anonfun$initializeSparkSession$1(KyuubiSparkUtil.scala:48)
   	at org.apache.kyuubi.engine.spark.KyuubiSparkUtil$.$anonfun$initializeSparkSession$1$adapted(KyuubiSparkUtil.scala:41)
   	at scala.collection.mutable.ResizableArray.foreach(ResizableArray.scala:62)
   	at scala.collection.mutable.ResizableArray.foreach$(ResizableArray.scala:55)
   	at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:49)
   	at org.apache.kyuubi.engine.spark.KyuubiSparkUtil$.initializeSparkSession(KyuubiSparkUtil.scala:41)
   	at org.apache.kyuubi.engine.spark.SparkSQLEngine$.createSpark(SparkSQLEngine.scala:206)
   	at org.apache.kyuubi.engine.spark.SparkSQLEngine$.main(SparkSQLEngine.scala:271)
   	at org.apache.kyuubi.engine.spark.SparkSQLEngine.main(SparkSQLEngine.scala)
   	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
   	at org.apache.spark.deploy.JavaMainApplication.start(SparkApplication.scala:52)
   	at org.apache.spark.deploy.SparkSubmit.org$apache$spark$deploy$SparkSubmit$$runMain(SparkSubmit.scala:955)
   	at org.apache.spark.deploy.SparkSubmit$$anon$1.run(SparkSubmit.scala:165)
   	at org.apache.spark.deploy.SparkSubmit$$anon$1.run(SparkSubmit.scala:163)
   	at java.base/java.security.AccessController.doPrivileged(Native Method)
   	at java.base/javax.security.auth.Subject.doAs(Subject.java:423)
   	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1878)
   	at org.apache.spark.deploy.SparkSubmit.doRunMain$1(SparkSubmit.scala:163)
   	at org.apache.spark.deploy.SparkSubmit.submit(SparkSubmit.scala:203)
   	at org.apache.spark.deploy.SparkSubmit.doSubmit(SparkSubmit.scala:90)
   	at org.apache.spark.deploy.SparkSubmit$$anon$2.doSubmit(SparkSubmit.scala:1043)
   	at org.apache.spark.deploy.SparkSubmit$.main(SparkSubmit.scala:1052)
   	at org.apache.spark.deploy.SparkSubmit.main(SparkSubmit.scala)
   ```
   Seems ask for executor resource timeout


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [kyuubi] zwangsheng commented on pull request #3691: [KYUUBI #3677][K8S] Bump Kubernetes Client Version to 6.1.1

Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on PR #3691:
URL: https://github.com/apache/kyuubi/pull/3691#issuecomment-1455361705

   Close for we need to bump 6.4.1 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #3691: [KYUUBI #3677][K8S] Bump Kubernetes Client Version to 6.1.1

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3691:
URL: https://github.com/apache/incubator-kyuubi/pull/3691#issuecomment-1296468236

   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/3691?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3691](https://codecov.io/gh/apache/incubator-kyuubi/pull/3691?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2c13f8e) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/40eed8c4a7e7a68b47a94e1174df6426e10d5f41?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (40eed8c) will **decrease** coverage by `0.01%`.
   > The diff coverage is `8.82%`.
   
   > :exclamation: Current head 2c13f8e differs from pull request most recent head 95bec8a. Consider uploading reports for the commit 95bec8a to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3691      +/-   ##
   ============================================
   - Coverage     52.46%   52.44%   -0.02%     
     Complexity       13       13              
   ============================================
     Files           490      490              
     Lines         27650    27660      +10     
     Branches       3824     3827       +3     
   ============================================
   + Hits          14506    14507       +1     
   - Misses        11760    11766       +6     
   - Partials       1384     1387       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/3691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...kyuubi/engine/KubernetesApplicationOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvS3ViZXJuZXRlc0FwcGxpY2F0aW9uT3BlcmF0aW9uLnNjYWxh) | `19.44% <0.00%> (-2.44%)` | :arrow_down: |
   | [...scala/org/apache/kyuubi/util/KubernetesUtils.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS91dGlsL0t1YmVybmV0ZXNVdGlscy5zY2FsYQ==) | `82.14% <100.00%> (+0.66%)` | :arrow_up: |
   | [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `91.17% <0.00%> (-0.30%)` | :arrow_down: |
   | [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `97.46% <0.00%> (-0.08%)` | :arrow_down: |
   | [...g/apache/kyuubi/operation/BatchJobSubmission.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vQmF0Y2hKb2JTdWJtaXNzaW9uLnNjYWxh) | `74.64% <0.00%> (ø)` | |
   | [...he/kyuubi/ha/client/etcd/EtcdDiscoveryClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9ldGNkL0V0Y2REaXNjb3ZlcnlDbGllbnQuc2NhbGE=) | `68.23% <0.00%> (+0.58%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #3691: [KYUUBI #3677][K8S] Bump Kubernetes Client Version to 6.1.1

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on PR #3691:
URL: https://github.com/apache/incubator-kyuubi/pull/3691#issuecomment-1298124992

   @zwangsheng  seems the failed tests is related ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] zwangsheng commented on pull request #3691: [KYUUBI #3677][K8S] Bump Kubernetes Client Version to 6.1.1

Posted by GitBox <gi...@apache.org>.
zwangsheng commented on PR #3691:
URL: https://github.com/apache/incubator-kyuubi/pull/3691#issuecomment-1296685529

   For there are some it test fail, i'd like find cause. And hope to have this PR first to help locate the problem. https://github.com/apache/incubator-kyuubi/pull/3728


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] zwangsheng commented on pull request #3691: [KYUUBI #3677][K8S] Bump Kubernetes Client Version to 6.1.1

Posted by GitBox <gi...@apache.org>.
zwangsheng commented on PR #3691:
URL: https://github.com/apache/incubator-kyuubi/pull/3691#issuecomment-1294557617

   Fail with some flaky test, cc @ulysses-you @pan3793 @yaooqinn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [kyuubi] zwangsheng closed pull request #3691: [KYUUBI #3677][K8S] Bump Kubernetes Client Version to 6.1.1

Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng closed pull request #3691: [KYUUBI #3677][K8S] Bump Kubernetes Client Version to 6.1.1 
URL: https://github.com/apache/kyuubi/pull/3691


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org