[GitHub] [druid] clintropolis commented on a change in pull request #11199: Fix vectorized cardinality bug on certain string columns.

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #11199:
URL: https://github.com/apache/druid/pull/11199#discussion_r628061017



##########
File path: processing/src/main/java/org/apache/druid/segment/VectorColumnProcessorFactory.java
##########
@@ -41,17 +41,25 @@
 public interface VectorColumnProcessorFactory<T>
 {
   /**
-   * Called when {@link ColumnCapabilities#getType()} is STRING and the underlying column always has a single value
+   * Called only if {@link ColumnCapabilities#getType()} is STRING and the underlying column always has a single value

Review comment:
       woops, I guess I only fixed up docs for `VectorColumnSelectorFactory` in #10613, should've done these too, my bad




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org