You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "michaelandrepearce (via GitHub)" <gi...@apache.org> on 2023/03/11 16:50:44 UTC

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a diff in pull request #86: allow acktype modified_failed

michaelandrepearce commented on code in PR #86:
URL: https://github.com/apache/activemq-nms-amqp/pull/86#discussion_r1133119148


##########
.github/GitVersion.yml:
##########
@@ -0,0 +1,6 @@
+assembly-versioning-scheme: MajorMinorPatch

Review Comment:
   -1



##########
src/NMS.AMQP/Apache-NMS-AMQP.csproj:
##########
@@ -32,7 +32,7 @@ with the License.  You may obtain a copy of the License at
 
     <PropertyGroup>
         <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
-        <PackageId>Apache.NMS.AMQP</PackageId>
+        <PackageId>Jef.Apache.NMS.AMQP</PackageId>

Review Comment:
   -1



##########
.github/workflows/publish.yml:
##########
@@ -0,0 +1,32 @@
+name: test and publish

Review Comment:
   -1 unrelated changes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org