You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "jakezhu9 (via GitHub)" <gi...@apache.org> on 2023/03/03 15:16:57 UTC
[GitHub] [incubator-devlake] jakezhu9 opened a new issue, #4584: [Bug][generator] incorrect import path in plugin template
jakezhu9 opened a new issue, #4584:
URL: https://github.com/apache/incubator-devlake/issues/4584
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues.
### What happened
I tried to create a new plugin following the instructions in the [docs](https://devlake.apache.org/docs/DeveloperManuals/PluginImplementation), but some of the code generated using the template had incorrect import paths. For example, the following import path was wrong:
```go
package main
import (
"github.com/apache/incubator-devlake/plugins/trello/impl"
"github.com/apache/incubator-devlake/runner" // incorrect
"github.com/spf13/cobra"
)
```
I also discovered that this issue was caused by #3884.
### What do you expect to happen
correct import path, for example
```go
package main
import (
"github.com/apache/incubator-devlake/plugins/trello/impl"
"github.com/apache/incubator-devlake/core/runner" // correct
"github.com/spf13/cobra"
)
```
### How to reproduce
```
go run generator/main.go create-plugin test
```
### Anything else
_No response_
### Version
main
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #4584: [Bug][generator] incorrect import path in plugin template
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4584:
URL: https://github.com/apache/incubator-devlake/issues/4584#issuecomment-1507758038
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] closed issue #4584: [Bug][generator] incorrect import path in plugin template
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #4584: [Bug][generator] incorrect import path in plugin template
URL: https://github.com/apache/incubator-devlake/issues/4584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #4584: [Bug][generator] incorrect import path in plugin template
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4584:
URL: https://github.com/apache/incubator-devlake/issues/4584#issuecomment-1499783162
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on issue #4584: [Bug][generator] incorrect import path in plugin template
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on issue #4584:
URL: https://github.com/apache/incubator-devlake/issues/4584#issuecomment-1455432997
Yup, we had a quite huge directory relocation recently, #2078 , the plugin templates are yet to be updated.
Besides, the current implementation doesn't utilize the `text/template` package from the golang stdlib which should be taken care of as well #4284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org