You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2017/05/03 10:53:07 UTC
Review Request 58956: LENS-1417: Add filters in cli create schema
command
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58956/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1417
https://issues.apache.org/jira/browse/LENS-1417
Repository: lens
Description
-------
create schema command is useful but it calls create/update for all the schema xml files. The following things will be useful:
* Option to specify entity type filter. e.g. create only cubes
* Option to specify file name filter. e.g. create only entities having `x` in their names
* Reporting all Failures collectively at the end.
The general flow in cli is to run a command, then for subsequent runs of the same command, one generally tends to use the command history and modify existing commands. So although there already exists a way to solve for point 2, but it involves writing another command. Having this filter will be helpful.
Diffs
-----
lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 76cb8b90e206eea076cf32b87d97617a833c3f91
lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 60bd9e074848c8579f1ad4edcd8e4873f40c4843
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java cdd101bfa4b6ce77492e1626491e58e570be03af
Diff: https://reviews.apache.org/r/58956/diff/1/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 58956: LENS-1417: Add filters in cli create schema
command
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 4, 2017, 5:42 p.m., Puneet Gupta wrote:
> > lens-regression/src/main/java/org/apache/lens/regression/util/Util.java
> > Lines 108 (patched)
> > <https://reviews.apache.org/r/58956/diff/2/?file=1708255#file1708255line108>
> >
> > Is this required ?
removed
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58956/#review173892
-----------------------------------------------------------
On May 4, 2017, 5:02 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58956/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 5:02 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1417
> https://issues.apache.org/jira/browse/LENS-1417
>
>
> Repository: lens
>
>
> Description
> -------
>
> create schema command is useful but it calls create/update for all the schema xml files. The following things will be useful:
>
> * Option to specify entity type filter. e.g. create only cubes
> * Option to specify file name filter. e.g. create only entities having `x` in their names
> * Reporting all Failures collectively at the end.
>
> The general flow in cli is to run a command, then for subsequent runs of the same command, one generally tends to use the command history and modify existing commands. So although there already exists a way to solve for point 2, but it involves writing another command. Having this filter will be helpful.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 76cb8b90e206eea076cf32b87d97617a833c3f91
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 60bd9e074848c8579f1ad4edcd8e4873f40c4843
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java cdd101bfa4b6ce77492e1626491e58e570be03af
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java 2370f3e8e2ce1dc4fa95cbce716355a7cf75a2d8
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 80ba912f43de4686f27732c54647a715f0514387
>
>
> Diff: https://reviews.apache.org/r/58956/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 58956: LENS-1417: Add filters in cli create schema
command
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58956/#review173892
-----------------------------------------------------------
lens-regression/src/main/java/org/apache/lens/regression/util/Util.java
Lines 108 (patched)
<https://reviews.apache.org/r/58956/#comment246971>
Is this required ?
- Puneet Gupta
On May 4, 2017, 11:32 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58956/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 11:32 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1417
> https://issues.apache.org/jira/browse/LENS-1417
>
>
> Repository: lens
>
>
> Description
> -------
>
> create schema command is useful but it calls create/update for all the schema xml files. The following things will be useful:
>
> * Option to specify entity type filter. e.g. create only cubes
> * Option to specify file name filter. e.g. create only entities having `x` in their names
> * Reporting all Failures collectively at the end.
>
> The general flow in cli is to run a command, then for subsequent runs of the same command, one generally tends to use the command history and modify existing commands. So although there already exists a way to solve for point 2, but it involves writing another command. Having this filter will be helpful.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 76cb8b90e206eea076cf32b87d97617a833c3f91
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 60bd9e074848c8579f1ad4edcd8e4873f40c4843
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java cdd101bfa4b6ce77492e1626491e58e570be03af
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java 2370f3e8e2ce1dc4fa95cbce716355a7cf75a2d8
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 80ba912f43de4686f27732c54647a715f0514387
>
>
> Diff: https://reviews.apache.org/r/58956/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 58956: LENS-1417: Add filters in cli create schema
command
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58956/#review173998
-----------------------------------------------------------
Ship it!
Ship It!
- Puneet Gupta
On May 4, 2017, 12:15 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58956/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 12:15 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1417
> https://issues.apache.org/jira/browse/LENS-1417
>
>
> Repository: lens
>
>
> Description
> -------
>
> create schema command is useful but it calls create/update for all the schema xml files. The following things will be useful:
>
> * Option to specify entity type filter. e.g. create only cubes
> * Option to specify file name filter. e.g. create only entities having `x` in their names
> * Reporting all Failures collectively at the end.
>
> The general flow in cli is to run a command, then for subsequent runs of the same command, one generally tends to use the command history and modify existing commands. So although there already exists a way to solve for point 2, but it involves writing another command. Having this filter will be helpful.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 76cb8b90e206eea076cf32b87d97617a833c3f91
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 60bd9e074848c8579f1ad4edcd8e4873f40c4843
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java cdd101bfa4b6ce77492e1626491e58e570be03af
>
>
> Diff: https://reviews.apache.org/r/58956/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 58956: LENS-1417: Add filters in cli create schema
command
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58956/
-----------------------------------------------------------
(Updated May 4, 2017, 5:45 p.m.)
Review request for lens.
Bugs: LENS-1417
https://issues.apache.org/jira/browse/LENS-1417
Repository: lens
Description
-------
create schema command is useful but it calls create/update for all the schema xml files. The following things will be useful:
* Option to specify entity type filter. e.g. create only cubes
* Option to specify file name filter. e.g. create only entities having `x` in their names
* Reporting all Failures collectively at the end.
The general flow in cli is to run a command, then for subsequent runs of the same command, one generally tends to use the command history and modify existing commands. So although there already exists a way to solve for point 2, but it involves writing another command. Having this filter will be helpful.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 76cb8b90e206eea076cf32b87d97617a833c3f91
lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 60bd9e074848c8579f1ad4edcd8e4873f40c4843
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java cdd101bfa4b6ce77492e1626491e58e570be03af
Diff: https://reviews.apache.org/r/58956/diff/3/
Changes: https://reviews.apache.org/r/58956/diff/2-3/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 58956: LENS-1417: Add filters in cli create schema
command
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58956/
-----------------------------------------------------------
(Updated May 4, 2017, 5:02 p.m.)
Review request for lens.
Bugs: LENS-1417
https://issues.apache.org/jira/browse/LENS-1417
Repository: lens
Description
-------
create schema command is useful but it calls create/update for all the schema xml files. The following things will be useful:
* Option to specify entity type filter. e.g. create only cubes
* Option to specify file name filter. e.g. create only entities having `x` in their names
* Reporting all Failures collectively at the end.
The general flow in cli is to run a command, then for subsequent runs of the same command, one generally tends to use the command history and modify existing commands. So although there already exists a way to solve for point 2, but it involves writing another command. Having this filter will be helpful.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 76cb8b90e206eea076cf32b87d97617a833c3f91
lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 60bd9e074848c8579f1ad4edcd8e4873f40c4843
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java cdd101bfa4b6ce77492e1626491e58e570be03af
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java 2370f3e8e2ce1dc4fa95cbce716355a7cf75a2d8
lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 80ba912f43de4686f27732c54647a715f0514387
Diff: https://reviews.apache.org/r/58956/diff/2/
Changes: https://reviews.apache.org/r/58956/diff/1-2/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 58956: LENS-1417: Add filters in cli create schema
command
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58956/#review173870
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java
Lines 62 (patched)
<https://reviews.apache.org/r/58956/#comment246960>
Should we make fileNameFilter case in-sensitive
- Puneet Gupta
On May 3, 2017, 10:53 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58956/
> -----------------------------------------------------------
>
> (Updated May 3, 2017, 10:53 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1417
> https://issues.apache.org/jira/browse/LENS-1417
>
>
> Repository: lens
>
>
> Description
> -------
>
> create schema command is useful but it calls create/update for all the schema xml files. The following things will be useful:
>
> * Option to specify entity type filter. e.g. create only cubes
> * Option to specify file name filter. e.g. create only entities having `x` in their names
> * Reporting all Failures collectively at the end.
>
> The general flow in cli is to run a command, then for subsequent runs of the same command, one generally tends to use the command history and modify existing commands. So although there already exists a way to solve for point 2, but it involves writing another command. Having this filter will be helpful.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 76cb8b90e206eea076cf32b87d97617a833c3f91
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 60bd9e074848c8579f1ad4edcd8e4873f40c4843
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java cdd101bfa4b6ce77492e1626491e58e570be03af
>
>
> Diff: https://reviews.apache.org/r/58956/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>