You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2014/07/23 15:08:07 UTC
Review Request 23854: Usability: HDFS Total Space Utilization chart data
needs more precision
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23854/
-----------------------------------------------------------
Review request for Ambari and Andriy Babiichuk.
Bugs: AMBARI-6578
https://issues.apache.org/jira/browse/AMBARI-6578
Repository: ambari
Description
-------
Switch Dashboard widget, HDFS > Services metrics chart, and other places in UI where we were using the ***GB version of metrics (such as CapacityTotalGB or CapacityUsedGB) to these instead, that are in bytes, providing more precision:
CapacityTotal
CapacityUsed
CapacityRemaining
CapacityNonDFSUsed
Note: when making this switch, need to do the units conversion so values are easy to read.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/services/HDFS/metrics.json c52a4c0
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/metrics.json be49109
ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/metrics.json fe33f71
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/metrics.json be49109
ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/metrics.json f33a0c0
ambari-web/app/messages.js 537b5f5
ambari-web/app/utils/ajax/ajax.js 976459a
ambari-web/app/views/main/service/info/metrics/hdfs/space_utilization.js 6bf00f0
Diff: https://reviews.apache.org/r/23854/diff/
Testing
-------
not applicable
Thanks,
Dmytro Sen
Re: Review Request 23854: Usability: HDFS Total Space Utilization chart data
needs more precision
Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23854/#review48646
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Antonenko
On July 23, 2014, 1:29 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23854/
> -----------------------------------------------------------
>
> (Updated July 23, 2014, 1:29 p.m.)
>
>
> Review request for Ambari, Andriy Babiichuk and Alexandr Antonenko.
>
>
> Bugs: AMBARI-6578
> https://issues.apache.org/jira/browse/AMBARI-6578
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Switch Dashboard widget, HDFS > Services metrics chart, and other places in UI where we were using the ***GB version of metrics (such as CapacityTotalGB or CapacityUsedGB) to these instead, that are in bytes, providing more precision:
> CapacityTotal
> CapacityUsed
> CapacityRemaining
> CapacityNonDFSUsed
> Note: when making this switch, need to do the units conversion so values are easy to read.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/services/HDFS/metrics.json c52a4c0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/metrics.json be49109
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/metrics.json fe33f71
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/metrics.json be49109
> ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/metrics.json f33a0c0
> ambari-web/app/messages.js 537b5f5
> ambari-web/app/utils/ajax/ajax.js 976459a
> ambari-web/app/views/main/service/info/metrics/hdfs/space_utilization.js 6bf00f0
>
> Diff: https://reviews.apache.org/r/23854/diff/
>
>
> Testing
> -------
>
> not applicable
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 23854: Usability: HDFS Total Space Utilization chart data
needs more precision
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23854/#review48656
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On July 24, 2014, 2:19 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23854/
> -----------------------------------------------------------
>
> (Updated July 24, 2014, 2:19 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-6578
> https://issues.apache.org/jira/browse/AMBARI-6578
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Switch Dashboard widget, HDFS > Services metrics chart, and other places in UI where we were using the ***GB version of metrics (such as CapacityTotalGB or CapacityUsedGB) to these instead, that are in bytes, providing more precision:
> CapacityTotal
> CapacityUsed
> CapacityRemaining
> CapacityNonDFSUsed
> Note: when making this switch, need to do the units conversion so values are easy to read.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/services/HDFS/metrics.json c52a4c0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/metrics.json be49109
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/metrics.json fe33f71
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/metrics.json be49109
> ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/metrics.json f33a0c0
> ambari-web/app/messages.js 537b5f5
> ambari-web/app/utils/ajax/ajax.js 976459a
> ambari-web/app/views/main/service/info/metrics/hdfs/space_utilization.js 6bf00f0
>
> Diff: https://reviews.apache.org/r/23854/diff/
>
>
> Testing
> -------
>
> not applicable
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 23854: Usability: HDFS Total Space Utilization chart data
needs more precision
Posted by Dmytro Shkvyra <ds...@hortonworks.com>.
> On July 24, 2014, 2:24 p.m., Dmitro Lisnichenko wrote:
> > We probably should remove old definitions like
> > metrics/dfs/FSNamesystem/CapacityUsedGB and metrics/dfs/FSNamesystem/CapacityTotalGB
> > if we are replacing them with more precise metrics
These properties can be read by REST API, and I'm not sure that it not used by customers. Let's leave it. They are not so heavy for server and removing these metrics need a lot of testing.
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23854/#review48647
-----------------------------------------------------------
On July 24, 2014, 2:19 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23854/
> -----------------------------------------------------------
>
> (Updated July 24, 2014, 2:19 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-6578
> https://issues.apache.org/jira/browse/AMBARI-6578
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Switch Dashboard widget, HDFS > Services metrics chart, and other places in UI where we were using the ***GB version of metrics (such as CapacityTotalGB or CapacityUsedGB) to these instead, that are in bytes, providing more precision:
> CapacityTotal
> CapacityUsed
> CapacityRemaining
> CapacityNonDFSUsed
> Note: when making this switch, need to do the units conversion so values are easy to read.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/services/HDFS/metrics.json c52a4c0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/metrics.json be49109
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/metrics.json fe33f71
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/metrics.json be49109
> ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/metrics.json f33a0c0
> ambari-web/app/messages.js 537b5f5
> ambari-web/app/utils/ajax/ajax.js 976459a
> ambari-web/app/views/main/service/info/metrics/hdfs/space_utilization.js 6bf00f0
>
> Diff: https://reviews.apache.org/r/23854/diff/
>
>
> Testing
> -------
>
> not applicable
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 23854: Usability: HDFS Total Space Utilization chart data
needs more precision
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23854/#review48647
-----------------------------------------------------------
We probably should remove old definitions like
metrics/dfs/FSNamesystem/CapacityUsedGB and metrics/dfs/FSNamesystem/CapacityTotalGB
if we are replacing them with more precise metrics
- Dmitro Lisnichenko
On July 24, 2014, 2:19 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23854/
> -----------------------------------------------------------
>
> (Updated July 24, 2014, 2:19 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-6578
> https://issues.apache.org/jira/browse/AMBARI-6578
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Switch Dashboard widget, HDFS > Services metrics chart, and other places in UI where we were using the ***GB version of metrics (such as CapacityTotalGB or CapacityUsedGB) to these instead, that are in bytes, providing more precision:
> CapacityTotal
> CapacityUsed
> CapacityRemaining
> CapacityNonDFSUsed
> Note: when making this switch, need to do the units conversion so values are easy to read.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/services/HDFS/metrics.json c52a4c0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/metrics.json be49109
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/metrics.json fe33f71
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/metrics.json be49109
> ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/metrics.json f33a0c0
> ambari-web/app/messages.js 537b5f5
> ambari-web/app/utils/ajax/ajax.js 976459a
> ambari-web/app/views/main/service/info/metrics/hdfs/space_utilization.js 6bf00f0
>
> Diff: https://reviews.apache.org/r/23854/diff/
>
>
> Testing
> -------
>
> not applicable
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 23854: Usability: HDFS Total Space Utilization chart data
needs more precision
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23854/
-----------------------------------------------------------
(Updated July 24, 2014, 2:19 p.m.)
Review request for Ambari, Alexandr Antonenko and Dmitro Lisnichenko.
Bugs: AMBARI-6578
https://issues.apache.org/jira/browse/AMBARI-6578
Repository: ambari
Description
-------
Switch Dashboard widget, HDFS > Services metrics chart, and other places in UI where we were using the ***GB version of metrics (such as CapacityTotalGB or CapacityUsedGB) to these instead, that are in bytes, providing more precision:
CapacityTotal
CapacityUsed
CapacityRemaining
CapacityNonDFSUsed
Note: when making this switch, need to do the units conversion so values are easy to read.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/services/HDFS/metrics.json c52a4c0
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/metrics.json be49109
ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/metrics.json fe33f71
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/metrics.json be49109
ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/metrics.json f33a0c0
ambari-web/app/messages.js 537b5f5
ambari-web/app/utils/ajax/ajax.js 976459a
ambari-web/app/views/main/service/info/metrics/hdfs/space_utilization.js 6bf00f0
Diff: https://reviews.apache.org/r/23854/diff/
Testing
-------
not applicable
Thanks,
Dmytro Sen
Re: Review Request 23854: Usability: HDFS Total Space Utilization chart data
needs more precision
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23854/
-----------------------------------------------------------
(Updated July 23, 2014, 1:29 p.m.)
Review request for Ambari, Andriy Babiichuk and Alexandr Antonenko.
Bugs: AMBARI-6578
https://issues.apache.org/jira/browse/AMBARI-6578
Repository: ambari
Description
-------
Switch Dashboard widget, HDFS > Services metrics chart, and other places in UI where we were using the ***GB version of metrics (such as CapacityTotalGB or CapacityUsedGB) to these instead, that are in bytes, providing more precision:
CapacityTotal
CapacityUsed
CapacityRemaining
CapacityNonDFSUsed
Note: when making this switch, need to do the units conversion so values are easy to read.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/services/HDFS/metrics.json c52a4c0
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/metrics.json be49109
ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/metrics.json fe33f71
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/metrics.json be49109
ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/metrics.json f33a0c0
ambari-web/app/messages.js 537b5f5
ambari-web/app/utils/ajax/ajax.js 976459a
ambari-web/app/views/main/service/info/metrics/hdfs/space_utilization.js 6bf00f0
Diff: https://reviews.apache.org/r/23854/diff/
Testing
-------
not applicable
Thanks,
Dmytro Sen