Re: [PR] CASSGO-9 Add more logging, a Structured Logger interface and log levels [cassandra-gocql-driver]

["jameshartig (via GitHub)" <gi...@apache.org>]

jameshartig commented on PR #1755:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1755#issuecomment-2874815489

   > I considered log/slog instead of creating a new Structured Logger interface from scratch but log/slog was only introduced in go 1.21 so I discarded this option for now.
   
   I'm hesitant to change anything major without considering how it will work with `log/slog`. The downside is that right now we can't directly use `slog.Attr`. We could make an identical type for older Go and in newer go use a type alias to `slog.Attr`. That said, I think `LogField` is close and we could make a `SlogLogger` wrapper in the future. What're your thoughts about more closely aligning with `slog`?
   
   > "message":"gocql: received topology change event: %v"
   
   What is the reason for keeping the printf verbs in the messages? Do we need to maintain backwards compatibility with old log messages?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org