You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/12/22 15:49:18 UTC
[kudu-CR] KUDU-1812. pb util: add a 'using' to import secure PB strings
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5561
to review the following change.
Change subject: KUDU-1812. pb_util: add a 'using' to import secure PB strings
......................................................................
KUDU-1812. pb_util: add a 'using' to import secure PB strings
This adds a bit of a style deviation and imports
pb_util::SecureDebugString into the 'kudu' namespace. This makes the
automatic replacement of Message::DebugString call sites much simpler
since we don't need to also worry about adding 'using' declarations to
every call site.
Change-Id: I3efc6a1c3d7f7f58a0f57511cf4d6fccc1f800bc
---
M src/kudu/util/pb_util.h
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/5561/1
--
To view, visit http://gerrit.cloudera.org:8080/5561
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3efc6a1c3d7f7f58a0f57511cf4d6fccc1f800bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] KUDU-1812. pb util: add a 'using' to import secure PB strings
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812. pb_util: add a 'using' to import secure PB strings
......................................................................
Patch Set 1:
it's actually been rolled into https://gerrit.cloudera.org/#/c/5562/
--
To view, visit http://gerrit.cloudera.org:8080/5561
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3efc6a1c3d7f7f58a0f57511cf4d6fccc1f800bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-1812. pb util: add a 'using' to import secure PB strings
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812. pb_util: add a 'using' to import secure PB strings
......................................................................
Patch Set 1:
or it will be
--
To view, visit http://gerrit.cloudera.org:8080/5561
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3efc6a1c3d7f7f58a0f57511cf4d6fccc1f800bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-1812. pb util: add a 'using' to import secure PB strings
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-1812. pb_util: add a 'using' to import secure PB strings
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5561
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3efc6a1c3d7f7f58a0f57511cf4d6fccc1f800bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-1812. pb util: add a 'using' to import secure PB strings
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has abandoned this change.
Change subject: KUDU-1812. pb_util: add a 'using' to import secure PB strings
......................................................................
Abandoned
This got rolled into https://gerrit.cloudera.org/#/c/5553/
--
To view, visit http://gerrit.cloudera.org:8080/5561
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I3efc6a1c3d7f7f58a0f57511cf4d6fccc1f800bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins