You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/24 06:49:04 UTC
[GitHub] [pulsar] zymap commented on a change in pull request #9016: Enable spotbugs check in the module pulsar-common
zymap commented on a change in pull request #9016:
URL: https://github.com/apache/pulsar/pull/9016#discussion_r548418620
##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarClassLoader.java
##########
@@ -151,11 +158,13 @@ public static NarClassLoader getFromArchive(File narPath, Set<String> additional
String narExtractionDirectory)
throws IOException {
File unpacked = NarUnpacker.unpackNar(narPath, getNarExtractionDirectory(narExtractionDirectory));
- try {
- return new NarClassLoader(unpacked, additionalJars, parent);
- } catch (ClassNotFoundException | NoClassDefFoundError e) {
- throw new IOException(e);
- }
+ return AccessController.doPrivileged(new PrivilegedAction<NarClassLoader>() {
Review comment:
Is this right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org