You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by nm...@apache.org on 2017/08/23 12:17:44 UTC
svn commit: r1805891 - in /ofbiz/ofbiz-plugins/trunk:
ecommerce/webapp/ecommerce/WEB-INF/controller.xml
example/webapp/example/WEB-INF/controller.xml
lucene/webapp/content/WEB-INF/controller.xml
pricat/webapp/pricatdemo/WEB-INF/controller.xml
Author: nmalin
Date: Wed Aug 23 12:17:44 2017
New Revision: 1805891
URL: http://svn.apache.org/viewvc?rev=1805891&view=rev
Log:
Fixed: Consistency and Readability improvements for view-map tag (OFBIZ-9110)
Consistency on the attribute order for view-map element as : name, type, page
Thanks to Ankush Upadhyay and Devanshu Vyas for the issue and the corrective patch
Modified:
ofbiz/ofbiz-plugins/trunk/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
ofbiz/ofbiz-plugins/trunk/example/webapp/example/WEB-INF/controller.xml
ofbiz/ofbiz-plugins/trunk/lucene/webapp/content/WEB-INF/controller.xml
ofbiz/ofbiz-plugins/trunk/pricat/webapp/pricatdemo/WEB-INF/controller.xml
Modified: ofbiz/ofbiz-plugins/trunk/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/ecommerce/webapp/ecommerce/WEB-INF/controller.xml?rev=1805891&r1=1805890&r2=1805891&view=diff
==============================================================================
--- ofbiz/ofbiz-plugins/trunk/ecommerce/webapp/ecommerce/WEB-INF/controller.xml (original)
+++ ofbiz/ofbiz-plugins/trunk/ecommerce/webapp/ecommerce/WEB-INF/controller.xml Wed Aug 23 12:17:44 2017
@@ -1971,7 +1971,7 @@ under the License.
<!-- Forum Views -->
<!-- new -->
<view-map name="Showforum" type="screen" page="component://ecommerce/widget/ForumScreens.xml#Showforum"/>
- <view-map name="AddForumThread" page="component://ecommerce/widget/ForumScreens.xml#AddForumThread" type="screen"/>
+ <view-map name="AddForumThread" type="screen" page="component://ecommerce/widget/ForumScreens.xml#AddForumThread"/>
<view-map name="ViewForumMessage" type="screen" page="component://ecommerce/widget/ForumScreens.xml#ViewForumMessage"/>
<!-- Quote Views -->
Modified: ofbiz/ofbiz-plugins/trunk/example/webapp/example/WEB-INF/controller.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/example/webapp/example/WEB-INF/controller.xml?rev=1805891&r1=1805890&r2=1805891&view=diff
==============================================================================
--- ofbiz/ofbiz-plugins/trunk/example/webapp/example/WEB-INF/controller.xml (original)
+++ ofbiz/ofbiz-plugins/trunk/example/webapp/example/WEB-INF/controller.xml Wed Aug 23 12:17:44 2017
@@ -282,8 +282,8 @@ under the License.
<view-map name="ExampleOsmGeoLocationPointSet4" type="screen" page="component://example/widget/example/ExampleScreens.xml#ExampleOsmGeoLocationPointSet4"/>
<!-- Flot view mapping -->
- <view-map name="ExampleBarChart" page="component://example/widget/example/ExampleScreens.xml#ExampleBarChart" type="screen"/>
- <view-map name="ExamplePieChart" page="component://example/widget/example/ExampleScreens.xml#ExamplePieChart" type="screen"/>
+ <view-map name="ExampleBarChart" type="screen" page="component://example/widget/example/ExampleScreens.xml#ExampleBarChart"/>
+ <view-map name="ExamplePieChart" type="screen" page="component://example/widget/example/ExampleScreens.xml#ExamplePieChart"/>
<!-- content FOP example -->
<view-map name="fonts.fo" type="screenfop" page="component://content/widget/CommonScreens.xml#fonts.fo" content-type="application/pdf" encoding="none"/>
Modified: ofbiz/ofbiz-plugins/trunk/lucene/webapp/content/WEB-INF/controller.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/lucene/webapp/content/WEB-INF/controller.xml?rev=1805891&r1=1805890&r2=1805891&view=diff
==============================================================================
--- ofbiz/ofbiz-plugins/trunk/lucene/webapp/content/WEB-INF/controller.xml (original)
+++ ofbiz/ofbiz-plugins/trunk/lucene/webapp/content/WEB-INF/controller.xml Wed Aug 23 12:17:44 2017
@@ -52,7 +52,7 @@ under the License.
</request-map>
<!-- View Mappings -->
- <view-map name="ProductSearch" page="component://lucene/widget/LuceneScreens.xml#ProductSearch" type="screen"/>
- <view-map name="AdminSearch" page="component://lucene/widget/LuceneScreens.xml#AdminSearch" type="screen"/>
- <view-map name="AdminIndex" page="component://lucene/widget/LuceneScreens.xml#AdminIndex" type="screen"/>
+ <view-map name="ProductSearch" type="screen" page="component://lucene/widget/LuceneScreens.xml#ProductSearch"/>
+ <view-map name="AdminSearch" type="screen" page="component://lucene/widget/LuceneScreens.xml#AdminSearch"/>
+ <view-map name="AdminIndex" type="screen" page="component://lucene/widget/LuceneScreens.xml#AdminIndex"/>
</site-conf>
\ No newline at end of file
Modified: ofbiz/ofbiz-plugins/trunk/pricat/webapp/pricatdemo/WEB-INF/controller.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/pricat/webapp/pricatdemo/WEB-INF/controller.xml?rev=1805891&r1=1805890&r2=1805891&view=diff
==============================================================================
--- ofbiz/ofbiz-plugins/trunk/pricat/webapp/pricatdemo/WEB-INF/controller.xml (original)
+++ ofbiz/ofbiz-plugins/trunk/pricat/webapp/pricatdemo/WEB-INF/controller.xml Wed Aug 23 12:17:44 2017
@@ -83,6 +83,6 @@ under the License.
<view-map name="main" type="screen" page="component://pricat/widget/SampleScreens.xml#main"/>
<view-map name="countdownreport" type="screen" page="component://pricat/widget/SampleScreens.xml#countdownreport"/>
<view-map name="countupreport" type="screen" page="component://pricat/widget/SampleScreens.xml#countupreport"/>
- <view-map name="SamplePricat" page="component://pricat/widget/SampleScreens.xml#SamplePricat" type="screen"/>
- <view-map name="parseSamplePricat" page="component://pricat/widget/SampleScreens.xml#parseSamplePricat" type="screen"/>
+ <view-map name="SamplePricat" type="screen" page="component://pricat/widget/SampleScreens.xml#SamplePricat"/>
+ <view-map name="parseSamplePricat" type="screen" page="component://pricat/widget/SampleScreens.xml#parseSamplePricat"/>
</site-conf>