[GitHub] [spark] srowen commented on a change in pull request #24263: [MINOR][DSTREAMS] Add DStreamCheckpointData.cleanup warning if delete returns false

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #24263: [MINOR][DSTREAMS] Add DStreamCheckpointData.cleanup warning if delete returns false
URL: https://github.com/apache/spark/pull/24263#discussion_r271287367
 
 

 ##########
 File path: streaming/src/main/scala/org/apache/spark/streaming/dstream/DStreamCheckpointData.scala
 ##########
 @@ -87,9 +87,12 @@ class DStreamCheckpointData[T: ClassTag](dstream: DStream[T])
               if (fileSystem == null) {
                 fileSystem = path.getFileSystem(dstream.ssc.sparkContext.hadoopConfiguration)
               }
-              fileSystem.delete(path, true)
+              if (fileSystem.delete(path, true)) {
+                logInfo("Deleted checkpoint file '" + file + "' for time " + time)
 
 Review comment:
   While you're welcome to use string interpolation here while you're at it, this seems fine

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org