[jira] [Commented] (LUCENE-6912) Grouping's Collectors should have smart needsScores()

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-6912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042039#comment-15042039 ] 

ASF subversion and git services commented on LUCENE-6912:
---------------------------------------------------------

Commit 1718009 from [~dsmiley] in branch 'dev/trunk'
[ https://svn.apache.org/r1718009 ]

LUCENE-6912: Grouping's Collectors now calculate a needsScores() instead of always 'true'.
In core, CachingCollector should have always returned true when scores are cached (small bug).

> Grouping's Collectors should have smart needsScores()
> -----------------------------------------------------
>
>                 Key: LUCENE-6912
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6912
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/grouping
>            Reporter: David Smiley
>            Assignee: David Smiley
>             Fix For: 5.5
>
>         Attachments: LUCENE_6912.patch
>
>
> The Grouping module has numerous Collector implementations, and only a couple perhaps override needsScore() with an optimal choice.  Lets do this for all of them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org