You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Robert Munteanu <rm...@adobe.com.INVALID> on 2017/05/15 12:44:34 UTC
Initial release of the content package support for the Installer?
Hi,
I am planning to perform an initial release of the
org.apache.sling.installer.factory.packages bundle, so that we can use
it in the Launchpad and include it in Sling 9.
I see that there are still 2 open issues, do we consider them blocking
for the release or can they be postponed?
Thanks,
Robert
Re: Initial release of the content package support for the
Installer?
Posted by Robert Munteanu <ro...@apache.org>.
On Mon, 2017-05-15 at 16:29 +0200, Konrad Windszus wrote:
> It would be good if someone from Adobe could confirm, but the sub
> package handling is different (sorry, not the dependency handling as
> being mentioned earlier).
>
> - In Sling the transform(...) uploads the package and returns only
> one TransformationResult. That is then processed by the Install or
> UninstallTask (by completely installing the package including all sub
> packages)
> - In AEM (Adobe Granite Installer for Content Packages v1.0.10) the
> transform calls uploads and the extractSubpackages to create
> (recursively) TransformationResults for all packages (even the nested
> ones). Each InstallTask then only install that one package (without
> any embedded packages).
>
> The latter seems better (for some reasoning look at https://issues.ap
> ache.org/jira/browse/JCRVLT-140).
> I kind of hoped that someone from Adobe would be able to donate that
> code as well.
The code we have in Sling was written from scratch, not donated. For
now I guess we'll have to do with the documentation and the information
we have.
Seeing as we don't have a lot of content packages in Sling - and
definitely no sub-packages I don't think this is a big deal for the
moment.
Robert
>
> Thanks,
> Konrad
>
> > On 15. May 2017, at 16:09, Robert Munteanu <ro...@apache.org>
> > wrote:
> >
> > Hi Konrad,
> >
> > Maybe you can add more information to the ticket regarding what
> > should
> > be added? I'm probably not the best person to provide a fix, but if
> > we
> > decide to hold the release for that issue we should know exactly
> > what
> > is required.
> >
> > Robert
> >
> > On Mon, 2017-05-15 at 15:58 +0200, Konrad Windszus wrote:
> > > When I compare now the factory in Sling with the one being
> > > shipped
> > > with AEM at least the dependency handling is quite different now.
> > > Maybe it would be worth looking into that (maybe in the context
> > > of ht
> > > tps://issues.apache.org/jira/browse/SLING-6657).
> > > Otherwise no objections.
> > > Konrad
> > >
> > > > On 15. May 2017, at 14:44, Robert Munteanu <rmuntean@adobe.com.
> > > > INVA
> > > > LID> wrote:
> > > >
> > > > Hi,
> > > >
> > > > I am planning to perform an initial release of the
> > > > org.apache.sling.installer.factory.packages bundle, so that we
> > > > can
> > > > use
> > > > it in the Launchpad and include it in Sling 9.
> > > >
> > > > I see that there are still 2 open issues, do we consider them
> > > > blocking
> > > > for the release or can they be postponed?
> > > >
> > > > Thanks,
> > > >
> > > > Robert
> > >
> > >
>
>
Re: Initial release of the content package support for the Installer?
Posted by Konrad Windszus <ko...@gmx.de>.
It would be good if someone from Adobe could confirm, but the sub package handling is different (sorry, not the dependency handling as being mentioned earlier).
- In Sling the transform(...) uploads the package and returns only one TransformationResult. That is then processed by the Install or UninstallTask (by completely installing the package including all sub packages)
- In AEM (Adobe Granite Installer for Content Packages v1.0.10) the transform calls uploads and the extractSubpackages to create (recursively) TransformationResults for all packages (even the nested ones). Each InstallTask then only install that one package (without any embedded packages).
The latter seems better (for some reasoning look at https://issues.apache.org/jira/browse/JCRVLT-140).
I kind of hoped that someone from Adobe would be able to donate that code as well.
Thanks,
Konrad
> On 15. May 2017, at 16:09, Robert Munteanu <ro...@apache.org> wrote:
>
> Hi Konrad,
>
> Maybe you can add more information to the ticket regarding what should
> be added? I'm probably not the best person to provide a fix, but if we
> decide to hold the release for that issue we should know exactly what
> is required.
>
> Robert
>
> On Mon, 2017-05-15 at 15:58 +0200, Konrad Windszus wrote:
>> When I compare now the factory in Sling with the one being shipped
>> with AEM at least the dependency handling is quite different now.
>> Maybe it would be worth looking into that (maybe in the context of ht
>> tps://issues.apache.org/jira/browse/SLING-6657).
>> Otherwise no objections.
>> Konrad
>>
>>> On 15. May 2017, at 14:44, Robert Munteanu <rmuntean@adobe.com.INVA
>>> LID> wrote:
>>>
>>> Hi,
>>>
>>> I am planning to perform an initial release of the
>>> org.apache.sling.installer.factory.packages bundle, so that we can
>>> use
>>> it in the Launchpad and include it in Sling 9.
>>>
>>> I see that there are still 2 open issues, do we consider them
>>> blocking
>>> for the release or can they be postponed?
>>>
>>> Thanks,
>>>
>>> Robert
>>
>>
>
Re: Initial release of the content package support for the
Installer?
Posted by Robert Munteanu <ro...@apache.org>.
Hi Konrad,
Maybe you can add more information to the ticket regarding what should
be added? I'm probably not the best person to provide a fix, but if we
decide to hold the release for that issue we should know exactly what
is required.
Robert
On Mon, 2017-05-15 at 15:58 +0200, Konrad Windszus wrote:
> When I compare now the factory in Sling with the one being shipped
> with AEM at least the dependency handling is quite different now.
> Maybe it would be worth looking into that (maybe in the context of ht
> tps://issues.apache.org/jira/browse/SLING-6657).
> Otherwise no objections.
> Konrad
>
> > On 15. May 2017, at 14:44, Robert Munteanu <rmuntean@adobe.com.INVA
> > LID> wrote:
> >
> > Hi,
> >
> > I am planning to perform an initial release of the
> > org.apache.sling.installer.factory.packages bundle, so that we can
> > use
> > it in the Launchpad and include it in Sling 9.
> >
> > I see that there are still 2 open issues, do we consider them
> > blocking
> > for the release or can they be postponed?
> >
> > Thanks,
> >
> > Robert
>
>
Re: Initial release of the content package support for the Installer?
Posted by Konrad Windszus <ko...@gmx.de>.
When I compare now the factory in Sling with the one being shipped with AEM at least the dependency handling is quite different now.
Maybe it would be worth looking into that (maybe in the context of https://issues.apache.org/jira/browse/SLING-6657).
Otherwise no objections.
Konrad
> On 15. May 2017, at 14:44, Robert Munteanu <rm...@adobe.com.INVALID> wrote:
>
> Hi,
>
> I am planning to perform an initial release of the
> org.apache.sling.installer.factory.packages bundle, so that we can use
> it in the Launchpad and include it in Sling 9.
>
> I see that there are still 2 open issues, do we consider them blocking
> for the release or can they be postponed?
>
> Thanks,
>
> Robert