[GitHub] [superset] ktmud commented on a change in pull request #13306: chore(spa refactor): refactoring dashboard to use api's instead of bootstrapdata

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #13306:
URL: https://github.com/apache/superset/pull/13306#discussion_r608885698



##########
File path: superset-frontend/src/dashboard/App.jsx
##########
@@ -25,22 +25,28 @@ import { HTML5Backend } from 'react-dnd-html5-backend';
 import { DynamicPluginProvider } from 'src/components/DynamicPlugins';
 import setupApp from '../setup/setupApp';
 import setupPlugins from '../setup/setupPlugins';
-import DashboardContainer from './containers/Dashboard';
+import DashboardRoute from './components/DashboardPage';

Review comment:
       ```suggestion
   import DashboardPage from './components/DashboardPage';
   ```
   
   Let's have more consistent component name? `DashboardPage.tsx` probably also don't need to live under `./components`. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org