You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2017/04/13 17:39:34 UTC

svn commit: r1791288 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/SOAPEventHandler.java

Author: jleroux
Date: Thu Apr 13 17:39:34 2017
New Revision: 1791288

URL: http://svn.apache.org/viewvc?rev=1791288&view=rev
Log:
Improved: SOAPEventHandler only outputs error to log when secureSoapAnswer 
= false
(OFBIZ-9289)

jleroux: I agree there is no risk showing information in log

Thanks: Gareth Carter

Modified:
    ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/SOAPEventHandler.java

Modified: ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/SOAPEventHandler.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/SOAPEventHandler.java?rev=1791288&r1=1791287&r2=1791288&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/SOAPEventHandler.java (original)
+++ ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/SOAPEventHandler.java Thu Apr 13 17:39:34 2017
@@ -199,6 +199,7 @@ public class SOAPEventHandler implements
                 createAndSendSOAPResponse(serviceResults, serviceName, response);
 
             } catch (GenericServiceException e) {
+                Debug.logError(e, module);
                 if (UtilProperties.getPropertyAsBoolean("service", "secureSoapAnswer", true)) {
                     sendError(response, "Problem processing the service, check your parameters.", serviceName);
                 } else {
@@ -207,7 +208,6 @@ public class SOAPEventHandler implements
                     } else {
                         sendError(response, e.getMessageList(), serviceName);
                     }
-                    Debug.logError(e, module);
                     return null;
                 }
             }