You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/10/18 22:05:50 UTC

Review Request 53001: GEODE-1927: more protection from seeing com.gemstone.gemfire packaged objects

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53001/
-----------------------------------------------------------

Review request for geode, Hitesh Khamesra, Udo Kohlmeyer, and Dan Smith.


Bugs: GEODE-1927
    https://issues.apache.org/jira/browse/GEODE-1927


Repository: geode


Description
-------

DeadlockDetector can read an archive of dependencies across the distributed system.  This adds a small ObjectInputStream modification to its method that reads these archives to let it handle those created before the package rename.


Diffs
-----

  geode-core/src/main/java/org/apache/geode/distributed/internal/deadlock/DeadlockDetector.java 2c70418e53b25edd3ae7cfe801e8f4b92ca1c3ec 

Diff: https://reviews.apache.org/r/53001/diff/


Testing
-------

manual testing with an old archive


Thanks,

Bruce Schuchardt


Re: Review Request 53001: GEODE-1927: more protection from seeing com.gemstone.gemfire packaged objects

Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53001/#review153187
-----------------------------------------------------------


Ship it!




Ship It!

- Dan Smith


On Oct. 18, 2016, 10:05 p.m., Bruce Schuchardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53001/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2016, 10:05 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra, Udo Kohlmeyer, and Dan Smith.
> 
> 
> Bugs: GEODE-1927
>     https://issues.apache.org/jira/browse/GEODE-1927
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> DeadlockDetector can read an archive of dependencies across the distributed system.  This adds a small ObjectInputStream modification to its method that reads these archives to let it handle those created before the package rename.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/deadlock/DeadlockDetector.java 2c70418e53b25edd3ae7cfe801e8f4b92ca1c3ec 
> 
> Diff: https://reviews.apache.org/r/53001/diff/
> 
> 
> Testing
> -------
> 
> manual testing with an old archive
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>


Re: Review Request 53001: GEODE-1927: more protection from seeing com.gemstone.gemfire packaged objects

Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53001/#review153192
-----------------------------------------------------------


Ship it!




Ship It!

- Hitesh Khamesra


On Oct. 18, 2016, 10:05 p.m., Bruce Schuchardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53001/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2016, 10:05 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra, Udo Kohlmeyer, and Dan Smith.
> 
> 
> Bugs: GEODE-1927
>     https://issues.apache.org/jira/browse/GEODE-1927
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> DeadlockDetector can read an archive of dependencies across the distributed system.  This adds a small ObjectInputStream modification to its method that reads these archives to let it handle those created before the package rename.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/deadlock/DeadlockDetector.java 2c70418e53b25edd3ae7cfe801e8f4b92ca1c3ec 
> 
> Diff: https://reviews.apache.org/r/53001/diff/
> 
> 
> Testing
> -------
> 
> manual testing with an old archive
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>