You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by gr...@apache.org on 2019/06/13 04:54:59 UTC
[incubator-superset] branch master updated: [SQL Lab] Fix proptypes
warning (#7691)
This is an automated email from the ASF dual-hosted git repository.
graceguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 2a453e1 [SQL Lab] Fix proptypes warning (#7691)
2a453e1 is described below
commit 2a453e18789157d915eaf77f63d83ca58f7a98ea
Author: Erik Ritter <er...@airbnb.com>
AuthorDate: Wed Jun 12 21:54:47 2019 -0700
[SQL Lab] Fix proptypes warning (#7691)
---
superset/assets/src/SqlLab/components/SouthPane.jsx | 2 +-
superset/assets/src/SqlLab/components/SqlEditor.jsx | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/superset/assets/src/SqlLab/components/SouthPane.jsx b/superset/assets/src/SqlLab/components/SouthPane.jsx
index 6da48ab..ab9e658 100644
--- a/superset/assets/src/SqlLab/components/SouthPane.jsx
+++ b/superset/assets/src/SqlLab/components/SouthPane.jsx
@@ -37,7 +37,7 @@ const TAB_HEIGHT = 44;
*/
const propTypes = {
editorQueries: PropTypes.array.isRequired,
- latestQueryId: PropTypes.string.isRequired,
+ latestQueryId: PropTypes.string,
dataPreviewQueries: PropTypes.array.isRequired,
actions: PropTypes.object.isRequired,
activeSouthPaneTab: PropTypes.string,
diff --git a/superset/assets/src/SqlLab/components/SqlEditor.jsx b/superset/assets/src/SqlLab/components/SqlEditor.jsx
index 880d2b8..9448a0b 100644
--- a/superset/assets/src/SqlLab/components/SqlEditor.jsx
+++ b/superset/assets/src/SqlLab/components/SqlEditor.jsx
@@ -308,7 +308,7 @@ class SqlEditor extends React.PureComponent {
</div>
<SouthPane
editorQueries={this.props.editorQueries}
- latestQueryId={this.props.latestQuery ? this.props.latestQuery.id : 0}
+ latestQueryId={this.props.latestQuery && this.props.latestQuery.id}
dataPreviewQueries={this.props.dataPreviewQueries}
actions={this.props.actions}
height={southPaneHeight}