[jira] [Comment Edited] (CAMEL-21695) Remove remaining camel-k code from camel-jbang

["Claudio Miranda (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-21695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922793#comment-17922793 ] 

Claudio Miranda edited comment on CAMEL-21695 at 2/2/25 12:17 PM:
------------------------------------------------------------------

[~davsclaus] About Pipe, should the "spec.integration" to be supported ?

{code:yaml}
apiVersion: camel.apache.org/v1
kind: Pipe
metadata:
    name: timer-event-source
spec:
    integration:
        dependencies:
        - "camel:cloudevents"
        traits:
            camel:
                properties:
                    - "foo=howdy"
                    - "bar=123"
            environment:
                vars:
                    - "MY_ENV=cheese"
    source:
        ref:
            kind: Kamelet
            apiVersion: camel.apache.org/v1
            name: timer-source
        properties:
            message: "Hello world!"
    sink:
        ref:
            kind: Kamelet
            apiVersion: camel.apache.org/v1
            name: log-sink
{code}

Also, the traits annotations 

{code}
apiVersion: camel.apache.org/v1
kind: Pipe
metadata:
    name: timer-event-source
    annotations:
        trait.camel.apache.org/camel.properties: "foo=howdy,bar=123"                  
        trait.camel.apache.org/environment.vars: "MY_ENV=cheese"                  
{code}

I think they are from camel-k so it would be safe to remove code that supports them ?


was (Author: claudio):
[~davsclaus] About Pipe, should the "spec.integration" to be supported ?

{code:yaml}
apiVersion: camel.apache.org/v1
kind: Pipe
metadata:
    name: timer-event-source
spec:
    integration:
    dependencies:
    - "camel:cloudevents"
    traits:
        camel:
        properties:
            - "foo=howdy"
            - "bar=123"
        environment:
        vars:
            - "MY_ENV=cheese"
    source:
    ref:
        kind: Kamelet
        apiVersion: camel.apache.org/v1
        name: timer-source
    properties:
        message: "Hello world!"
    sink:
    ref:
        kind: Kamelet
        apiVersion: camel.apache.org/v1
        name: log-sink
{code}

Also, the traits annotations 

{code}
apiVersion: camel.apache.org/v1
kind: Pipe
metadata:
    name: timer-event-source
    annotations:
    trait.camel.apache.org/camel.properties: "foo=howdy,bar=123"                  
    trait.camel.apache.org/environment.vars: "MY_ENV=cheese"                  

{code}

I think they are from camel-k so it would be safe to remove code that supports them ?

> Remove remaining camel-k code from camel-jbang
> ----------------------------------------------
>
>                 Key: CAMEL-21695
>                 URL: https://issues.apache.org/jira/browse/CAMEL-21695
>             Project: Camel
>          Issue Type: Improvement
>            Reporter: Claudio Miranda
>            Assignee: Claudio Miranda
>            Priority: Major
>
> The camel-jbang-plugin-k is scheduled to be removed from camel-jbang 4.10, there are many remaining traces from camel-k in camel-jbang:
>  * modeline: this should be marked as deprecated with a warning message if used
>  * kameletbinding: to be removed, replaced by Pipe
>  * documentation: remove several mentions of camel k
>  * examples: there are various examples in tests, remove them or replace with yaml dsl if necessary.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)