You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/07/15 07:06:42 UTC

[GitHub] [incubator-livy] yiheng opened a new pull request #180: [LIVY-582][Tests] Hostname in python-api test should be lower case to avoid test failures

yiheng opened a new pull request #180: [LIVY-582][Tests] Hostname in python-api test should be lower case to avoid test failures
URL: https://github.com/apache/incubator-livy/pull/180
 
 
   ## What changes were proposed in this pull request?
   In the python-API test code, when returning a mocked response, the mock lib will compare the URL with the predefined URLs case sensitive. However, the `Request` lib used in the Livy python API will change the URL to lower case. This will cause test failures on a machine with an upper case hostname.
   
   This patch turns the hostname in python-API test code into the lower case to avoid such test failures.
   
   ## How was this patch tested?
   Existing test. Run test specifically on a machine with an upper case hostname.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services