You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/10 11:39:06 UTC

[GitHub] [airflow] potiuk opened a new pull request #7393: [AIRLFOW-6766] Fix "cannot import ensure_text" error for pre-commit

potiuk opened a new pull request #7393: [AIRLFOW-6766] Fix "cannot import ensure_text" error for pre-commit
URL: https://github.com/apache/airflow/pull/7393
 
 
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] feluelle commented on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit

Posted by GitBox <gi...@apache.org>.
feluelle commented on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit
URL: https://github.com/apache/airflow/pull/7393#issuecomment-584094581
 
 
   > I prefer to add everything in scripts executed from Travis. Adding more stuff that just configuration to yaml quickly becomes painful. The ci_before_install.sh is what "before_install" executes.
   
   +0, I am fine with it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit
URL: https://github.com/apache/airflow/pull/7393#issuecomment-584082902
 
 
   We need to merge that quickly to stop people from failing their prs

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit
URL: https://github.com/apache/airflow/pull/7393#issuecomment-584093459
 
 
   > Wouldn't it be better to add this to the .travis.yml directly?
   > 
   > `before_install` for example?
   > 
   > Because locally it does not occur, right? So it is more related to travis than it is for our CI.
   
   I prefer to add everything in scripts executed from Travis. Adding more stuff that just configuration to yaml quickly becomes painful. The ci_before_install.sh is  what "before_install" executes.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit
URL: https://github.com/apache/airflow/pull/7393#issuecomment-584098534
 
 
   It's already succeeded with the first build, so I am merging it now 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit
URL: https://github.com/apache/airflow/pull/7393#issuecomment-584097484
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=h1) Report
   > Merging [#7393](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/1464f16eabab8f3d6ab936a2cd2a3127f1536863?src=pr&el=desc) will **increase** coverage by `53.63%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7393/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #7393       +/-   ##
   ===========================================
   + Coverage   32.59%   86.22%   +53.63%     
   ===========================================
     Files         871      871               
     Lines       40660    40660               
   ===========================================
   + Hits        13253    35059    +21806     
   + Misses      27407     5601    -21806
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | :arrow_up: |
   | [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `86.95% <0%> (+0.72%)` | :arrow_up: |
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (+2.1%)` | :arrow_up: |
   | [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
   | [airflow/utils/decorators.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kZWNvcmF0b3JzLnB5) | `90.47% <0%> (+4.76%)` | :arrow_up: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `92.25% <0%> (+5.63%)` | :arrow_up: |
   | [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `52.94% <0%> (+5.88%)` | :arrow_up: |
   | [airflow/www/forms.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvZm9ybXMucHk=) | `100% <0%> (+8%)` | :arrow_up: |
   | [airflow/utils/timeout.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy90aW1lb3V0LnB5) | `75% <0%> (+8.33%)` | :arrow_up: |
   | [airflow/kubernetes/kube\_client.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL2t1YmVfY2xpZW50LnB5) | `85.71% <0%> (+8.57%)` | :arrow_up: |
   | ... and [732 more](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=footer). Last update [1464f16...906e72b](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] feluelle commented on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit

Posted by GitBox <gi...@apache.org>.
feluelle commented on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit
URL: https://github.com/apache/airflow/pull/7393#issuecomment-584099000
 
 
   Yes, thanks a lot @potiuk 👍 :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk merged pull request #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit
URL: https://github.com/apache/airflow/pull/7393
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit
URL: https://github.com/apache/airflow/pull/7393#issuecomment-584097484
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=h1) Report
   > Merging [#7393](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/1464f16eabab8f3d6ab936a2cd2a3127f1536863?src=pr&el=desc) will **increase** coverage by `53.63%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7393/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #7393       +/-   ##
   ===========================================
   + Coverage   32.59%   86.22%   +53.63%     
   ===========================================
     Files         871      871               
     Lines       40660    40660               
   ===========================================
   + Hits        13253    35059    +21806     
   + Misses      27407     5601    -21806
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | :arrow_up: |
   | [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `86.95% <0%> (+0.72%)` | :arrow_up: |
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (+2.1%)` | :arrow_up: |
   | [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
   | [airflow/utils/decorators.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kZWNvcmF0b3JzLnB5) | `90.47% <0%> (+4.76%)` | :arrow_up: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `92.25% <0%> (+5.63%)` | :arrow_up: |
   | [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `52.94% <0%> (+5.88%)` | :arrow_up: |
   | [airflow/www/forms.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvZm9ybXMucHk=) | `100% <0%> (+8%)` | :arrow_up: |
   | [airflow/utils/timeout.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy90aW1lb3V0LnB5) | `75% <0%> (+8.33%)` | :arrow_up: |
   | [airflow/kubernetes/kube\_client.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL2t1YmVfY2xpZW50LnB5) | `85.71% <0%> (+8.57%)` | :arrow_up: |
   | ... and [732 more](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=footer). Last update [1464f16...c5947a9](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] feluelle commented on a change in pull request #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit

Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit
URL: https://github.com/apache/airflow/pull/7393#discussion_r377032019
 
 

 ##########
 File path: scripts/ci/ci_before_install.sh
 ##########
 @@ -33,6 +33,7 @@ KUBERNETES_MODE=${KUBERNETES_MODE:=""}
 
 mkdir -p "${AIRFLOW_SOURCES}/files"
 
-sudo pip install pre-commit
+# We need to install six apparently
 
 Review comment:
   LGTM, but keep in mind that we need to change this comment when we move to GitHub Actions / remove this commit entirely ;)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit
URL: https://github.com/apache/airflow/pull/7393#issuecomment-584097484
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=h1) Report
   > Merging [#7393](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/1464f16eabab8f3d6ab936a2cd2a3127f1536863?src=pr&el=desc) will **increase** coverage by `53.8%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7393/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master   #7393      +/-   ##
   =========================================
   + Coverage   32.59%   86.4%   +53.8%     
   =========================================
     Files         871     871              
     Lines       40660   40660              
   =========================================
   + Hits        13253   35131   +21878     
   + Misses      27407    5529   -21878
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | :arrow_up: |
   | [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `86.95% <0%> (+0.72%)` | :arrow_up: |
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (+2.1%)` | :arrow_up: |
   | [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
   | [airflow/utils/decorators.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kZWNvcmF0b3JzLnB5) | `90.47% <0%> (+4.76%)` | :arrow_up: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `92.25% <0%> (+5.63%)` | :arrow_up: |
   | [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `85.29% <0%> (+38.23%)` | :arrow_up: |
   | [airflow/www/forms.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvZm9ybXMucHk=) | `100% <0%> (+8%)` | :arrow_up: |
   | [airflow/utils/timeout.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy90aW1lb3V0LnB5) | `75% <0%> (+8.33%)` | :arrow_up: |
   | [airflow/kubernetes/kube\_client.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL2t1YmVfY2xpZW50LnB5) | `85.71% <0%> (+8.57%)` | :arrow_up: |
   | ... and [732 more](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=footer). Last update [1464f16...c5947a9](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit
URL: https://github.com/apache/airflow/pull/7393#discussion_r377031324
 
 

 ##########
 File path: scripts/ci/ci_before_install.sh
 ##########
 @@ -33,6 +33,7 @@ KUBERNETES_MODE=${KUBERNETES_MODE:=""}
 
 mkdir -p "${AIRFLOW_SOURCES}/files"
 
-sudo pip install pre-commit
+# We need to install six apparently
 
 Review comment:
   ```suggestion
   # We need newer version of six for Travis as they bundle 1.11.0 version
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit
URL: https://github.com/apache/airflow/pull/7393#discussion_r377023299
 
 

 ##########
 File path: scripts/ci/ci_before_install.sh
 ##########
 @@ -33,6 +33,7 @@ KUBERNETES_MODE=${KUBERNETES_MODE:=""}
 
 mkdir -p "${AIRFLOW_SOURCES}/files"
 
-sudo pip install pre-commit
+# We need to install six apparently
+sudo pip install pre-commit six==1.14.0
 
 Review comment:
   ```suggestion
   sudo pip install pre-commit 'six~=1.14'
   ```
   
   What do you thin?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit
URL: https://github.com/apache/airflow/pull/7393#issuecomment-584097484
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=h1) Report
   > Merging [#7393](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/1464f16eabab8f3d6ab936a2cd2a3127f1536863?src=pr&el=desc) will **increase** coverage by `53.63%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7393/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #7393       +/-   ##
   ===========================================
   + Coverage   32.59%   86.22%   +53.63%     
   ===========================================
     Files         871      871               
     Lines       40660    40660               
   ===========================================
   + Hits        13253    35059    +21806     
   + Misses      27407     5601    -21806
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | :arrow_up: |
   | [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `86.95% <0%> (+0.72%)` | :arrow_up: |
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (+2.1%)` | :arrow_up: |
   | [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
   | [airflow/utils/decorators.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kZWNvcmF0b3JzLnB5) | `90.47% <0%> (+4.76%)` | :arrow_up: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `92.25% <0%> (+5.63%)` | :arrow_up: |
   | [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `52.94% <0%> (+5.88%)` | :arrow_up: |
   | [airflow/www/forms.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvZm9ybXMucHk=) | `100% <0%> (+8%)` | :arrow_up: |
   | [airflow/utils/timeout.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy90aW1lb3V0LnB5) | `75% <0%> (+8.33%)` | :arrow_up: |
   | [airflow/kubernetes/kube\_client.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL2t1YmVfY2xpZW50LnB5) | `85.71% <0%> (+8.57%)` | :arrow_up: |
   | ... and [732 more](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=footer). Last update [1464f16...c5947a9](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit
URL: https://github.com/apache/airflow/pull/7393#discussion_r377025772
 
 

 ##########
 File path: scripts/ci/ci_before_install.sh
 ##########
 @@ -33,6 +33,7 @@ KUBERNETES_MODE=${KUBERNETES_MODE:=""}
 
 mkdir -p "${AIRFLOW_SOURCES}/files"
 
-sudo pip install pre-commit
+# We need to install six apparently
+sudo pip install pre-commit six==1.14.0
 
 Review comment:
   Yeah. Indeed can be like that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] Fokko commented on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit

Posted by GitBox <gi...@apache.org>.
Fokko commented on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit
URL: https://github.com/apache/airflow/pull/7393#issuecomment-584098875
 
 
   Thanks @potiuk 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit
URL: https://github.com/apache/airflow/pull/7393#issuecomment-584097484
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=h1) Report
   > Merging [#7393](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/1464f16eabab8f3d6ab936a2cd2a3127f1536863?src=pr&el=desc) will **increase** coverage by `53.99%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7393/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #7393       +/-   ##
   ===========================================
   + Coverage   32.59%   86.58%   +53.99%     
   ===========================================
     Files         871      871               
     Lines       40660    40660               
   ===========================================
   + Hits        13253    35207    +21954     
   + Misses      27407     5453    -21954
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | :arrow_up: |
   | [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `86.95% <0%> (+0.72%)` | :arrow_up: |
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (+2.1%)` | :arrow_up: |
   | [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (+3.57%)` | :arrow_up: |
   | [airflow/utils/decorators.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kZWNvcmF0b3JzLnB5) | `90.47% <0%> (+4.76%)` | :arrow_up: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `92.25% <0%> (+5.63%)` | :arrow_up: |
   | [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `85.29% <0%> (+38.23%)` | :arrow_up: |
   | [airflow/www/forms.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvZm9ybXMucHk=) | `100% <0%> (+8%)` | :arrow_up: |
   | [airflow/utils/timeout.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy90aW1lb3V0LnB5) | `75% <0%> (+8.33%)` | :arrow_up: |
   | [airflow/kubernetes/kube\_client.py](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL2t1YmVfY2xpZW50LnB5) | `85.71% <0%> (+8.57%)` | :arrow_up: |
   | ... and [732 more](https://codecov.io/gh/apache/airflow/pull/7393/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=footer). Last update [1464f16...c5947a9](https://codecov.io/gh/apache/airflow/pull/7393?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] Fokko commented on a change in pull request #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit

Posted by GitBox <gi...@apache.org>.
Fokko commented on a change in pull request #7393: [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit
URL: https://github.com/apache/airflow/pull/7393#discussion_r377029393
 
 

 ##########
 File path: scripts/ci/ci_before_install.sh
 ##########
 @@ -33,6 +33,7 @@ KUBERNETES_MODE=${KUBERNETES_MODE:=""}
 
 mkdir -p "${AIRFLOW_SOURCES}/files"
 
-sudo pip install pre-commit
+# We need to install six apparently
 
 Review comment:
   Technically this isn't correct since six is already installed, but an older (and incompatible) version:
   ```
   ERROR: virtualenv 20.0.0 has requirement six<2,>=1.12.0, but you'll have six 1.11.0 which is incompatible.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services