You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/05/08 00:02:26 UTC
[Impala-ASF-CR] IMPALA-9736: fix mt dop not supported error
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15884
Change subject: IMPALA-9736: fix mt_dop not supported error
......................................................................
IMPALA-9736: fix mt_dop not supported error
The error was not accurate, because joins are now
supported. Also updated it to refer to DML statements
instead of table sinks to be more user-appropriate.
Change-Id: I8eb8106f86c47a14cc951c4a77966fe51b5c30e3
---
M fe/src/main/java/org/apache/impala/planner/Planner.java
M testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation.test
2 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/15884/1
--
To view, visit http://gerrit.cloudera.org:8080/15884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8eb8106f86c47a14cc951c4a77966fe51b5c30e3
Gerrit-Change-Number: 15884
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9736: fix mt dop not supported error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15884 )
Change subject: IMPALA-9736: fix mt_dop not supported error
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8eb8106f86c47a14cc951c4a77966fe51b5c30e3
Gerrit-Change-Number: 15884
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 10 May 2020 00:18:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9736: fix mt dop not supported error
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/15884 )
Change subject: IMPALA-9736: fix mt_dop not supported error
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8eb8106f86c47a14cc951c4a77966fe51b5c30e3
Gerrit-Change-Number: 15884
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 May 2020 01:31:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9736: fix mt dop not supported error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15884 )
Change subject: IMPALA-9736: fix mt_dop not supported error
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5796/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8eb8106f86c47a14cc951c4a77966fe51b5c30e3
Gerrit-Change-Number: 15884
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 May 2020 19:04:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9736: fix mt dop not supported error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15884 )
Change subject: IMPALA-9736: fix mt_dop not supported error
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6000/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8eb8106f86c47a14cc951c4a77966fe51b5c30e3
Gerrit-Change-Number: 15884
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 00:55:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9736: fix mt dop not supported error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15884 )
Change subject: IMPALA-9736: fix mt_dop not supported error
......................................................................
IMPALA-9736: fix mt_dop not supported error
The error was not accurate, because joins are now
supported. Also updated it to refer to DML statements
instead of table sinks to be more user-appropriate.
Change-Id: I8eb8106f86c47a14cc951c4a77966fe51b5c30e3
Reviewed-on: http://gerrit.cloudera.org:8080/15884
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/planner/Planner.java
M testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation.test
2 files changed, 3 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8eb8106f86c47a14cc951c4a77966fe51b5c30e3
Gerrit-Change-Number: 15884
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9736: fix mt dop not supported error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15884 )
Change subject: IMPALA-9736: fix mt_dop not supported error
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8eb8106f86c47a14cc951c4a77966fe51b5c30e3
Gerrit-Change-Number: 15884
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 May 2020 19:04:58 +0000
Gerrit-HasComments: No