[PR] Helm chart: fix nodePort rendering in service.yaml [polaris]

["adutra (via GitHub)" <gi...@apache.org>]

adutra opened a new pull request, #3791:
URL: https://github.com/apache/polaris/pull/3791

   The template was incorrectly testing for the NodePort type, but other service types may need a nodePort as well, e.g. LoadBalancer. Other service templates were correct (they are not checking the service type for nodePort).
   
   <!--
   📝 Describe what changes you're proposing, especially breaking or user-facing changes. 
   📖 See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more.
   -->
   
   ## Checklist
   - [ ] 🛡️ Don't disclose security issues! (contact security@apache.org)
   - [ ] 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
   - [ ] 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
   - [ ] 💡 Added comments for complex logic
   - [ ] 🧾 Updated `CHANGELOG.md` (if needed)
   - [ ] 📚 Updated documentation in `site/content/in-dev/unreleased` (if needed)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Helm chart: fix nodePort rendering in service.yaml [polaris]

["adutra (via GitHub)" <gi...@apache.org>]

adutra merged PR #3791:
URL: https://github.com/apache/polaris/pull/3791


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org