(superset) branch master updated: fix: typescript errors in 4.0 (#27402)

[jo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new ce0b70cc86 fix: typescript errors in 4.0 (#27402)
ce0b70cc86 is described below

commit ce0b70cc8685aa4d83c0c4ad0fb8f03fb7e28ede
Author: JUST.in DO IT <ju...@airbnb.com>
AuthorDate: Wed Mar 6 10:16:51 2024 -0800

    fix: typescript errors in 4.0 (#27402)
---
 .../packages/superset-ui-core/src/query/api/v1/makeApi.ts           | 4 ++--
 .../src/components/AlteredSliceTag/AlteredSliceTagMocks.ts          | 2 +-
 superset-frontend/src/components/AlteredSliceTag/index.tsx          | 6 +++---
 superset-frontend/src/components/TelemetryPixel/index.tsx           | 1 +
 4 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/superset-frontend/packages/superset-ui-core/src/query/api/v1/makeApi.ts b/superset-frontend/packages/superset-ui-core/src/query/api/v1/makeApi.ts
index 900197fcb6..dc62b9094b 100644
--- a/superset-frontend/packages/superset-ui-core/src/query/api/v1/makeApi.ts
+++ b/superset-frontend/packages/superset-ui-core/src/query/api/v1/makeApi.ts
@@ -115,11 +115,11 @@ export default function makeApi<
         jsonPayload: undefined as JsonObject | undefined,
       };
       if (requestType === 'search') {
-        requestConfig.searchParams = payload as URLSearchParams;
+        requestConfig.searchParams = payload as unknown as URLSearchParams;
       } else if (requestType === 'rison') {
         requestConfig.endpoint = `${endpoint}?q=${rison.encode(payload)}`;
       } else if (requestType === 'form') {
-        requestConfig.postPayload = payload as FormData;
+        requestConfig.postPayload = payload as unknown as FormData;
       } else {
         requestConfig.jsonPayload = payload as JsonObject;
       }
diff --git a/superset-frontend/src/components/AlteredSliceTag/AlteredSliceTagMocks.ts b/superset-frontend/src/components/AlteredSliceTag/AlteredSliceTagMocks.ts
index 233f519446..6428b503b8 100644
--- a/superset-frontend/src/components/AlteredSliceTag/AlteredSliceTagMocks.ts
+++ b/superset-frontend/src/components/AlteredSliceTag/AlteredSliceTagMocks.ts
@@ -17,7 +17,7 @@
  * under the License.
  */
 import { QueryFormData } from '@superset-ui/core';
-import { ControlPanelConfig } from 'packages/superset-ui-chart-controls/src/types';
+import { ControlPanelConfig } from '@superset-ui/chart-controls';
 import { DiffType, RowType } from './index';
 
 export const defaultProps: Record<string, Partial<QueryFormData>> = {
diff --git a/superset-frontend/src/components/AlteredSliceTag/index.tsx b/superset-frontend/src/components/AlteredSliceTag/index.tsx
index dfedc9f5b6..28f47657b9 100644
--- a/superset-frontend/src/components/AlteredSliceTag/index.tsx
+++ b/superset-frontend/src/components/AlteredSliceTag/index.tsx
@@ -179,7 +179,7 @@ class AlteredSliceTag extends React.Component<
         return '[]';
       }
       return value
-        .map(v => {
+        .map((v: FilterItemType) => {
           const filterVal =
             v.comparator && v.comparator.constructor === Array
               ? `[${v.comparator.join(', ')}]`
@@ -198,14 +198,14 @@ class AlteredSliceTag extends React.Component<
       return value.map(v => safeStringify(v)).join(', ');
     }
     if (controlsMap[key]?.type === 'MetricsControl' && Array.isArray(value)) {
-      const formattedValue = value.map(v => v?.label ?? v);
+      const formattedValue = value.map((v: FilterItemType) => v?.label ?? v);
       return formattedValue.length ? formattedValue.join(', ') : '[]';
     }
     if (typeof value === 'boolean') {
       return value ? 'true' : 'false';
     }
     if (Array.isArray(value)) {
-      const formattedValue = value.map(v => v?.label ?? v);
+      const formattedValue = value.map((v: FilterItemType) => v?.label ?? v);
       return formattedValue.length ? formattedValue.join(', ') : '[]';
     }
     if (typeof value === 'string' || typeof value === 'number') {
diff --git a/superset-frontend/src/components/TelemetryPixel/index.tsx b/superset-frontend/src/components/TelemetryPixel/index.tsx
index 6c7ce106e6..f0223ac70d 100644
--- a/superset-frontend/src/components/TelemetryPixel/index.tsx
+++ b/superset-frontend/src/components/TelemetryPixel/index.tsx
@@ -47,6 +47,7 @@ const TelemetryPixel = ({
   const pixelPath = `https://apachesuperset.gateway.scarf.sh/pixel/${PIXEL_ID}/${version}/${sha}/${build}`;
   return process.env.SCARF_ANALYTICS === 'false' ? null : (
     <img
+      // @ts-ignore
       referrerPolicy="no-referrer-when-downgrade"
       src={pixelPath}
       width={0}