You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/01/31 13:45:40 UTC

[GitHub] spark pull request #19984: [SPARK-22789] Map-only continuous processing exec...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19984#discussion_r165055237
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingRelation.scala ---
    @@ -75,6 +76,52 @@ case class StreamingExecutionRelation(
       )
     }
     
    +// We have to pack in the V1 data source as a shim, for the case when a source implements
    +// continuous processing (which is always V2) but only has V1 microbatch support. We don't
    +// know at read time whether the query is conntinuous or not, so we need to be able to
    --- End diff --
    
    can't we know it from the specified trigger?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org