You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by scela <gi...@git.apache.org> on 2017/06/07 09:17:24 UTC
[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0
GitHub user scela opened a pull request:
https://github.com/apache/maven-indexer/pull/17
Migration to Lucene 6.1.0
This PR migrates maven-indexer to Lucene 6.1.0.
I did 'maven clean verify' and the tests seem to succeed. I'll be around to refine it in case the need arises.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scela/maven-indexer master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-indexer/pull/17.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17
----
commit 40f782a5727c781504c34bc2bcb390178dd18931
Author: Sopot Cela <sc...@redhat.com>
Date: 2017-06-07T09:15:04Z
Migration to Lucene 6.1.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0
Posted by carlspring <gi...@git.apache.org>.
Github user carlspring commented on a diff in the pull request:
https://github.com/apache/maven-indexer/pull/17#discussion_r130204917
--- Diff: indexer-core/pom.xml ---
@@ -84,21 +84,25 @@ under the License.
<dependency>
<groupId>org.apache.lucene</groupId>
<artifactId>lucene-core</artifactId>
+ <version>6.1.0</version>
--- End diff --
Yeah, that's the place! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0
Posted by carlspring <gi...@git.apache.org>.
Github user carlspring commented on a diff in the pull request:
https://github.com/apache/maven-indexer/pull/17#discussion_r130086143
--- Diff: indexer-core/src/main/java/org/apache/maven/index/FieldTypeFactory.java ---
@@ -0,0 +1,19 @@
+package org.apache.maven.index;
+
+import org.apache.lucene.document.FieldType;
+
+public class FieldTypeFactory {
+
+ private static StoredNotAnalyzedFieldType snaft = new StoredNotAnalyzedFieldType();
--- End diff --
Could you also please use the project's code formatting convention?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-indexer issue #17: Migration to Lucene 6.1.0
Posted by scela <gi...@git.apache.org>.
Github user scela commented on the issue:
https://github.com/apache/maven-indexer/pull/17
Sure. Can you point me where the Jira project is hosted? Lucene usually
makes major changes so I suspect going to 6.6 would be much more work. I'd
prefer to move to 6.1 first and then after that in a second iteration I
could port to later versions when I get the chance.
On Fri, Jul 28, 2017 at 6:46 AM, Olivier Lamy <no...@github.com>
wrote:
> @scela <https://github.com/scela> maybe you can create a Jira entry for
> the project?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/maven-indexer/pull/17#issuecomment-318558398>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAynN98AyjcQreCRXP07du_MmXbHfI_tks5sSWfDgaJpZM4NybNK>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0
Posted by carlspring <gi...@git.apache.org>.
Github user carlspring commented on a diff in the pull request:
https://github.com/apache/maven-indexer/pull/17#discussion_r130085893
--- Diff: indexer-core/pom.xml ---
@@ -84,21 +84,25 @@ under the License.
<dependency>
<groupId>org.apache.lucene</groupId>
<artifactId>lucene-core</artifactId>
+ <version>6.1.0</version>
--- End diff --
Hi,
Just a small remark, if I may -- this is not the right place to be changing the version. There is a version property defined in the aggregator's `pom.xml`. You should be changing that instead.
Cheers,
Martin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0
Posted by scela <gi...@git.apache.org>.
Github user scela closed the pull request at:
https://github.com/apache/maven-indexer/pull/17
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-indexer issue #17: Migration to Lucene 6.1.0
Posted by scela <gi...@git.apache.org>.
Github user scela commented on the issue:
https://github.com/apache/maven-indexer/pull/17
https://issues.apache.org/jira/browse/MINDEXER-104 Done
On Fri, Jul 28, 2017 at 3:43 PM, Martin Todorov <no...@github.com>
wrote:
> @scela <https://github.com/scela> ,
>
> You can file a new issue under MINDEXER
> <https://issues.apache.org/jira/browse/MINDEXER> Jira.
>
> Cheers,
>
> Martin
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/maven-indexer/pull/17#issuecomment-318655224>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAynNyS7MGa-xCyki6_UpDGIXoYWmaDHks5sSeVlgaJpZM4NybNK>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-indexer issue #17: Migration to Lucene 6.1.0
Posted by cstamas <gi...@git.apache.org>.
Github user cstamas commented on the issue:
https://github.com/apache/maven-indexer/pull/17
@olamy @scela sounds fine to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-indexer issue #17: Migration to Lucene 6.1.0
Posted by olamy <gi...@git.apache.org>.
Github user olamy commented on the issue:
https://github.com/apache/maven-indexer/pull/17
@scela fair enough. But as Lucene API change really often... Maybe migrate to the latest now so we are safe for a bit of time :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0
Posted by scela <gi...@git.apache.org>.
Github user scela commented on a diff in the pull request:
https://github.com/apache/maven-indexer/pull/17#discussion_r130093790
--- Diff: indexer-core/src/main/java/org/apache/maven/index/FieldTypeFactory.java ---
@@ -0,0 +1,19 @@
+package org.apache.maven.index;
+
+import org.apache.lucene.document.FieldType;
+
+public class FieldTypeFactory {
+
+ private static StoredNotAnalyzedFieldType snaft = new StoredNotAnalyzedFieldType();
--- End diff --
Sure. Does this mean I have to put the long name there?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0
Posted by scela <gi...@git.apache.org>.
Github user scela commented on a diff in the pull request:
https://github.com/apache/maven-indexer/pull/17#discussion_r130105466
--- Diff: indexer-core/pom.xml ---
@@ -84,21 +84,25 @@ under the License.
<dependency>
<groupId>org.apache.lucene</groupId>
<artifactId>lucene-core</artifactId>
+ <version>6.1.0</version>
--- End diff --
https://github.com/apache/maven-indexer/blob/master/pom.xml#L91 here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-indexer issue #17: Migration to Lucene 6.1.0
Posted by carlspring <gi...@git.apache.org>.
Github user carlspring commented on the issue:
https://github.com/apache/maven-indexer/pull/17
@scela ,
You can file a new issue under [MINDEXER](https://issues.apache.org/jira/browse/MINDEXER) Jira.
Cheers,
Martin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0
Posted by carlspring <gi...@git.apache.org>.
Github user carlspring commented on a diff in the pull request:
https://github.com/apache/maven-indexer/pull/17#discussion_r130101051
--- Diff: indexer-core/src/main/java/org/apache/maven/index/FieldTypeFactory.java ---
@@ -0,0 +1,19 @@
+package org.apache.maven.index;
+
+import org.apache.lucene.document.FieldType;
+
+public class FieldTypeFactory {
+
+ private static StoredNotAnalyzedFieldType snaft = new StoredNotAnalyzedFieldType();
--- End diff --
No, I believe you're using tabs, instead of spaces.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-indexer issue #17: Migration to Lucene 6.1.0
Posted by scela <gi...@git.apache.org>.
Github user scela commented on the issue:
https://github.com/apache/maven-indexer/pull/17
I'll be preparing a migration directly to just-released Lucene 7.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-indexer issue #17: Migration to Lucene 6.1.0
Posted by olamy <gi...@git.apache.org>.
Github user olamy commented on the issue:
https://github.com/apache/maven-indexer/pull/17
@scela maybe you can create a Jira entry for the project?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-indexer issue #17: Migration to Lucene 6.1.0
Posted by carlspring <gi...@git.apache.org>.
Github user carlspring commented on the issue:
https://github.com/apache/maven-indexer/pull/17
The changes, (despite my minor remarks), look good! Thanks for this pull! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0
Posted by carlspring <gi...@git.apache.org>.
Github user carlspring commented on a diff in the pull request:
https://github.com/apache/maven-indexer/pull/17#discussion_r130087375
--- Diff: indexer-core/src/test/java/org/apache/maven/index/FullIndexNexusIndexerTest.java ---
@@ -1,26 +1,8 @@
package org.apache.maven.index;
-/*
--- End diff --
So, what happened to the license header? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-indexer issue #17: Migration to Lucene 6.1.0
Posted by olamy <gi...@git.apache.org>.
Github user olamy commented on the issue:
https://github.com/apache/maven-indexer/pull/17
what about last one 6.6.0? :-)
@cstamas do you have any issues with that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org