You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/09/18 01:28:12 UTC
[GitHub] [incubator-mxnet] DickJC123 opened a new pull request #19175: FwdPort of "1.x-Backport Add cmake flag USE_FATBIN_COMPRESSION, ON by default (#19123) (#19158)"
DickJC123 opened a new pull request #19175:
URL: https://github.com/apache/incubator-mxnet/pull/19175
During the 1.x backporting of master-branch PR https://github.com/apache/incubator-mxnet/pull/19123 (as PR
https://github.com/apache/incubator-mxnet/pull/19158), some issues were discovered and corrected. This PR "forward ports" the result so that the logic behind use of fatbin compression remains consistent between master and v1.x.
Currently, master has the following issues:
If CMAKE_CUDA_FLAGS were already set, to say "--foo=bar", then that env var would be altered incorrectly to "--foo=bar--fatbin-options -compress-all"
Also, if USE_SPLIT_ARCH_DLL=OFF and MSVC=1, there would be no fatbin compression, even with USE_FATBIN_COMPRESSION=ON.
This PR corrects these issues, and so makes master behave like v1.x.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] DickJC123 commented on pull request #19175: FwdPort of "1.x-Backport Add cmake flag USE_FATBIN_COMPRESSION, ON by default (#19123) (#19158)"
Posted by GitBox <gi...@apache.org>.
DickJC123 commented on pull request #19175:
URL: https://github.com/apache/incubator-mxnet/pull/19175#issuecomment-696822714
@szha @leezu This small PR is ready for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu merged pull request #19175: FwdPort of "1.x-Backport Add cmake flag USE_FATBIN_COMPRESSION, ON by default (#19123) (#19158)"
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #19175:
URL: https://github.com/apache/incubator-mxnet/pull/19175
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] DickJC123 commented on pull request #19175: FwdPort of "1.x-Backport Add cmake flag USE_FATBIN_COMPRESSION, ON by default (#19123) (#19158)"
Posted by GitBox <gi...@apache.org>.
DickJC123 commented on pull request #19175:
URL: https://github.com/apache/incubator-mxnet/pull/19175#issuecomment-696822714
@szha @leezu This small PR is ready for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu merged pull request #19175: FwdPort of "1.x-Backport Add cmake flag USE_FATBIN_COMPRESSION, ON by default (#19123) (#19158)"
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #19175:
URL: https://github.com/apache/incubator-mxnet/pull/19175
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19175: FwdPort of "1.x-Backport Add cmake flag USE_FATBIN_COMPRESSION, ON by default (#19123) (#19158)"
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19175:
URL: https://github.com/apache/incubator-mxnet/pull/19175#issuecomment-695020426
@mxnet-bot run ci [centos-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19175: FwdPort of "1.x-Backport Add cmake flag USE_FATBIN_COMPRESSION, ON by default (#19123) (#19158)"
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19175:
URL: https://github.com/apache/incubator-mxnet/pull/19175#issuecomment-695020458
Jenkins CI successfully triggered : [centos-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19175: FwdPort of "1.x-Backport Add cmake flag USE_FATBIN_COMPRESSION, ON by default (#19123) (#19158)"
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19175:
URL: https://github.com/apache/incubator-mxnet/pull/19175#issuecomment-694594971
Hey @DickJC123 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-gpu, windows-cpu, clang, centos-gpu, miscellaneous, unix-cpu, edge, website, centos-cpu, unix-gpu, sanity]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org