[GitHub] [superset] kgabryje commented on a change in pull request #17369: fix: Database selector overflow

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #17369:
URL: https://github.com/apache/superset/pull/17369#discussion_r744703314



##########
File path: superset-frontend/src/components/DatabaseSelector/index.tsx
##########
@@ -97,8 +107,10 @@ const SelectLabel = ({
   databaseName: string;
 }) => (
   <LabelStyle>
-    <Label>{backend}</Label>
-    {databaseName}
+    <Label className="backend">{backend}</Label>

Review comment:
       Would it be better if we created separate styled components instead of adding classes to the container?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org