You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by markap14 <gi...@git.apache.org> on 2017/08/03 19:55:49 UTC
[GitHub] nifi pull request #2053: NIFI-3329: Removed check for latest version of flow...
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2053
NIFI-3329: Removed check for latest version of flowfile when migratin…
…g flowfile from 1 session to another because we now longer are requiring latest version of flowfile be passed to session anywhere else. It was intended to be removed from StandardProcessSession.migrate when it was removed from StandardProcessSession.validateRecordState but it was overlooked.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-3329
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2053.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2053
----
commit ef0785f37a6bd410b7dd66d1ce6107ed9b5d9c07
Author: Mark Payne <ma...@hotmail.com>
Date: 2017-08-03T19:55:19Z
NIFI-3329: Removed check for latest version of flowfile when migrating flowfile from 1 session to another because we now longer are requiring latest version of flowfile be passed to session anywhere else. It was intended to be removed from StandardProcessSession.migrate when it was removed from StandardProcessSession.validateRecordState but it was overlooked.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2053: NIFI-3329: Removed check for latest version of flowfile wh...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2053
i cleared out all the repos. Dropped the queue threshold to 5000 (from 40000) to avoid swapping and i'm not seeing that issue. I cant reason over how/if they're related but just an FYI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #2053: NIFI-3329: Removed check for latest version of flow...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2053
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2053: NIFI-3329: Removed check for latest version of flowfile wh...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2053
@joewitt when you say "i keep seeing issues with provenance" do you see the same stack trace over and over? Or do you see different issues? I do not believe that the provenance issue is related. I also don't believe it to be related to swapping. I believe what resolved the issue is that you cleared out the repo. My guess is that something happened to get you into that state, and it would have stayed in that state until you cleared the prov repo. Now just trying to understand the issue. From looking at the code, if it hits the above error, it should simply move on without compressing that event file. I'm wondering though if you see some other stack trace where another part of the prov repo won't move on?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2053: NIFI-3329: Removed check for latest version of flowfile wh...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2053
good catch. all the automated builds seem to have tanked but doing one last local confirmation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2053: NIFI-3329: Removed check for latest version of flowfile wh...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2053
in reviewing i keep seeing issues with provenance. Probably unrelated but does it make sense?
2017-08-03 17:48:04,182 ERROR [Compress Provenance Logs-1-thread-1] o.a.n.p.s.EventFileCompressor Failed to read TOC File ./provenance_repository/toc/167962066.toc
java.io.EOFException: null
at org.apache.nifi.provenance.toc.StandardTocReader.<init>(StandardTocReader.java:48)
at org.apache.nifi.provenance.serialization.EventFileCompressor.run(EventFileCompressor.java:93)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---