You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by co...@apache.org on 2016/06/20 05:00:57 UTC

zeppelin git commit: [ZEPPELIN-1020] Remove suggestion list on click

Repository: zeppelin
Updated Branches:
  refs/heads/master 5a4aacef2 -> 7fd9a6600


[ZEPPELIN-1020] Remove suggestion list on click

### What is this PR for?
The suggestion list under note permissions for readers, writers & owners should hide on-click anywhere on the notebook.

### What type of PR is it?
[Bug Fix]

### Todos

### What is the Jira issue?
[ZEPPELIN-1020](https://issues.apache.org/jira/browse/ZEPPELIN-1020)

### How should this be tested?
1.Click on any field for setting permission for owners, readers & writers.
2.The suggestion list is displayed.
3.Now, click on any part of the notebook the suggestion list hides.

### Screenshots (if appropriate)

**BEFORE:**
http://g.recordit.co/7Esaq245Tp.gif

**AFTER**
http://g.recordit.co/Rfgn5dONPz.gif

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: suvam97 <su...@gmail.com>
Author: System Administrator <ro...@HW-c82a143827ce.local>

Closes #1027 from suvam97/ZEPPELIN-1020 and squashes the following commits:

29870cd [suvam97] changed $ to angular.element
c9ef56c [suvam97] add angular.element in place of $
4372f49 [System Administrator] remove suggestion list on click


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/7fd9a660
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/7fd9a660
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/7fd9a660

Branch: refs/heads/master
Commit: 7fd9a66000dc549c4f08a0078aa70b6403cf4e34
Parents: 5a4aace
Author: suvam97 <su...@gmail.com>
Authored: Sat Jun 18 08:37:46 2016 -0700
Committer: Damien CORNEAU <co...@gmail.com>
Committed: Mon Jun 20 14:00:43 2016 +0900

----------------------------------------------------------------------
 zeppelin-web/src/app/notebook/notebook.controller.js | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/7fd9a660/zeppelin-web/src/app/notebook/notebook.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/notebook.controller.js b/zeppelin-web/src/app/notebook/notebook.controller.js
index 32c659f..944402a 100644
--- a/zeppelin-web/src/app/notebook/notebook.controller.js
+++ b/zeppelin-web/src/app/notebook/notebook.controller.js
@@ -879,6 +879,7 @@ angular.module('zeppelinWebApp').controller('NotebookCtrl',
 
   // function to find suggestion list on change
   $scope.search = function(role) {
+    angular.element('.userlist').show();
     convertToArray(role);
     checkPreviousRole(role);
     getChangedIndex();
@@ -950,5 +951,8 @@ angular.module('zeppelinWebApp').controller('NotebookCtrl',
     $scope.suggestions = [];
   };
 
+angular.element(document).click(function(){
+     angular.element('.userlist').hide();
+});
 
 });