[GitHub] algorri94 opened a new issue #5660: Hide 'Edit Dashboard' Button on Dashboard View

[GitBox <gi...@apache.org>]

algorri94 opened a new issue #5660: Hide 'Edit Dashboard' Button on Dashboard View
URL: https://github.com/apache/incubator-superset/issues/5660
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [X] I have checked the superset logs for python stacktraces and included it here as text if any
   - [X] I have reproduced the issue with at least the latest released version of superset
   - [X] I have checked the issue tracker for the same issue and I haven't found one similar
   
   
   ### Superset version
   0.26.3 built from source
   
   ### Expected results
   Not showing 'Edit Dashboard' button on the top right of the dashboard view if the user has no permissions to edit the dashboard.
   
   ### Actual results
   The button is always visible, even if the user has no permission to edit the dashboard. Then when you try to save it if you don't have permissions, it pops an error message. I think the users that can only read shouldn't see that button.
   
   ![Error](https://i.imgur.com/rVRSiqW.png)
   
   This is the error I get when I try to save it.
   
   ### Steps to reproduce
   I haven't found anything related to this. I'm new to Superset and Flask so I'm not sure if this is easy to fix or not, or even if it's possible.
   If it's doable I could do it myself with some guidance.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org