[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #4200: controlbus: Added action option tests (fixes #4009)

[GitBox <gi...@apache.org>]

jamesnetherton commented on code in PR #4200:
URL: https://github.com/apache/camel-quarkus/pull/4200#discussion_r1000614582


##########
integration-test-groups/foundation/controlbus/pom.xml:
##########
@@ -58,6 +62,20 @@
     </dependencies>
 
     <profiles>
+        <!--
+        <profile>
+            <id>jvm</id>

Review Comment:
   Do we need this profile given the JVM specific tests we're moved elsewhere?



##########
integration-test-groups/foundation/controlbus/src/test/java/org/apache/camel/quarkus/component/controlbus/it/ControlbusTest.java:
##########
@@ -19,13 +19,22 @@
 import io.quarkus.test.junit.QuarkusTest;
 import io.restassured.RestAssured;
 import io.restassured.http.ContentType;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
 @QuarkusTest
 class ControlbusTest {
 
+    @BeforeEach
+    public void startRoute() {
+        String status = RestAssured.get("/controlbus/status").asString();
+        if ("Stopped".equals(status)) {
+            RestAssured.get("/controlbus/start");
+        }
+    }
+
     @Test
-    public void test() {
+    public void testStopStart() {
         RestAssured.given()
                 .contentType(ContentType.TEXT).get("/controlbus/status")
                 .then().body(org.hamcrest.CoreMatchers.equalTo("Started"));

Review Comment:
   Nitpick - You can add a static import for `equalTo`. Makes things a bit easier to read without the package prefix.



##########
integration-tests-jvm/controlbus-statistics/src/main/java/org/apache/camel/quarkus/component/controlbus/it/ControlbusRoute.java:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.controlbus.it;
+
+import javax.enterprise.context.ApplicationScoped;
+
+import org.apache.camel.builder.RouteBuilder;
+import org.jboss.logging.Logger;
+
+@ApplicationScoped
+public class ControlbusRoute extends RouteBuilder {
+
+    private static final Logger LOG = Logger.getLogger(ControlbusResource.class);
+
+    @Override
+    public void configure() throws Exception {
+        from("direct:control")
+                .routeId("control")
+                .process(e -> LOG.info("control:" + e.getMessage().getBody(String.class)));
+
+        from("direct:status")
+                .transform()
+                .exchange(e -> e.getContext().getRouteController().getRouteStatus("control").name());

Review Comment:
   It's probably enough to do `.setBody().constant(getCamelContext().getRouteController().getRouteStatus("control"))`.



##########
integration-tests-jvm/controlbus-statistics/src/main/java/org/apache/camel/quarkus/component/controlbus/it/ControlbusRoute.java:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.controlbus.it;
+
+import javax.enterprise.context.ApplicationScoped;
+
+import org.apache.camel.builder.RouteBuilder;
+import org.jboss.logging.Logger;
+
+@ApplicationScoped
+public class ControlbusRoute extends RouteBuilder {
+
+    private static final Logger LOG = Logger.getLogger(ControlbusResource.class);
+
+    @Override
+    public void configure() throws Exception {
+        from("direct:control")
+                .routeId("control")
+                .process(e -> LOG.info("control:" + e.getMessage().getBody(String.class)));

Review Comment:
   If you add `camel-quarkus-log` as a dependency, then you can use the `log` EIP instead of needing a custom `Logger` instance & processor. E.g:
   
   ```
   .log("control: ${body}");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org