You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by sa...@apache.org on 2022/10/27 21:05:52 UTC
[ignite-3] branch main updated: IGNITE-18004 Compilation fixed, test disabled. (#1268)
This is an automated email from the ASF dual-hosted git repository.
sanpwc pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/main by this push:
new 4b5db8ddf4 IGNITE-18004 Compilation fixed, test disabled. (#1268)
4b5db8ddf4 is described below
commit 4b5db8ddf4a81e213384c0e4fc64576525b33645
Author: Alexander Lapin <la...@gmail.com>
AuthorDate: Fri Oct 28 00:05:47 2022 +0300
IGNITE-18004 Compilation fixed, test disabled. (#1268)
---
.../ignite/internal/sql/engine/ItDataTypesTest.java | 2 ++
.../org/apache/ignite/internal/app/IgniteImpl.java | 3 ++-
.../ignite/internal/sql/engine/SqlQueryProcessor.java | 8 ++++++--
.../internal/sql/engine/StopCalciteModuleTest.java | 7 ++++++-
.../internal/sql/engine/exec/MockedStructuresTest.java | 18 ++++++++++++------
5 files changed, 28 insertions(+), 10 deletions(-)
diff --git a/modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java b/modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java
index 064e991806..1fb2969a45 100644
--- a/modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java
+++ b/modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java
@@ -26,6 +26,7 @@ import java.util.Set;
import java.util.stream.Collectors;
import org.apache.calcite.runtime.CalciteContextException;
import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
/**
@@ -46,6 +47,7 @@ public class ItDataTypesTest extends AbstractBasicIntegrationTest {
/** Tests correctness with unicode. */
@Test
+ @Disabled("https://issues.apache.org/jira/browse/IGNITE-18005")
public void testUnicodeStrings() {
sql("CREATE TABLE string_table(key int primary key, val varchar)");
diff --git a/modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java b/modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java
index 6c4b0145a1..13ad6f99c7 100644
--- a/modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java
+++ b/modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java
@@ -399,7 +399,8 @@ public class IgniteImpl implements Ignite {
schemaManager,
dataStorageMgr,
txManager,
- () -> dataStorageModules.collectSchemasFields(modules.distributed().polymorphicSchemaExtensions())
+ () -> dataStorageModules.collectSchemasFields(modules.distributed().polymorphicSchemaExtensions()),
+ clock
);
sql = new IgniteSqlImpl(qryEngine);
diff --git a/modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java b/modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java
index 3f86aae8af..b3fdf34019 100644
--- a/modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java
+++ b/modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java
@@ -141,6 +141,8 @@ public class SqlQueryProcessor implements QueryProcessor {
/** Transaction manager. */
private final TxManager txManager;
+ private HybridClock clock;
+
/** Constructor. */
public SqlQueryProcessor(
Consumer<Function<Long, CompletableFuture<?>>> registry,
@@ -150,7 +152,8 @@ public class SqlQueryProcessor implements QueryProcessor {
SchemaManager schemaManager,
DataStorageManager dataStorageManager,
TxManager txManager,
- Supplier<Map<String, Map<String, Class<?>>>> dataStorageFieldsSupplier
+ Supplier<Map<String, Map<String, Class<?>>>> dataStorageFieldsSupplier,
+ HybridClock clock
) {
this.registry = registry;
this.clusterSrvc = clusterSrvc;
@@ -160,6 +163,7 @@ public class SqlQueryProcessor implements QueryProcessor {
this.dataStorageManager = dataStorageManager;
this.txManager = txManager;
this.dataStorageFieldsSupplier = dataStorageFieldsSupplier;
+ this.clock = clock;
}
/** {@inheritDoc} */
@@ -390,7 +394,7 @@ public class SqlQueryProcessor implements QueryProcessor {
})
.thenCompose(sqlNode -> {
final boolean rwOp = dataModificationOp(sqlNode);
- final HybridTimestamp txTime = outerTx != null ? outerTx.readTimestamp() : rwOp ? null : new HybridClock().now();
+ final HybridTimestamp txTime = outerTx != null ? outerTx.readTimestamp() : rwOp ? null : clock.now();
BaseQueryContext ctx = BaseQueryContext.builder()
.frameworkConfig(
diff --git a/modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/StopCalciteModuleTest.java b/modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/StopCalciteModuleTest.java
index c1f7c9fb12..7c95dad225 100644
--- a/modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/StopCalciteModuleTest.java
+++ b/modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/StopCalciteModuleTest.java
@@ -47,6 +47,7 @@ import java.util.function.Function;
import org.apache.ignite.configuration.ConfigurationValue;
import org.apache.ignite.internal.configuration.testframework.ConfigurationExtension;
import org.apache.ignite.internal.configuration.testframework.InjectConfiguration;
+import org.apache.ignite.internal.hlc.HybridClock;
import org.apache.ignite.internal.index.IndexManager;
import org.apache.ignite.internal.logger.IgniteLogger;
import org.apache.ignite.internal.logger.Loggers;
@@ -127,6 +128,9 @@ public class StopCalciteModuleTest {
@Mock
InternalTable tbl;
+ @Mock
+ HybridClock clock;
+
SchemaRegistry schemaReg;
TestRevisionRegister testRevisionRegister = new TestRevisionRegister();
@@ -216,7 +220,8 @@ public class StopCalciteModuleTest {
schemaManager,
dataStorageManager,
txManager,
- Map::of
+ Map::of,
+ clock
);
when(tbl.tableId()).thenReturn(UUID.randomUUID());
diff --git a/modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/MockedStructuresTest.java b/modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/MockedStructuresTest.java
index cfc331940d..4e1ff890a6 100644
--- a/modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/MockedStructuresTest.java
+++ b/modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/MockedStructuresTest.java
@@ -48,7 +48,7 @@ import org.apache.ignite.internal.configuration.notifications.ConfigurationStora
import org.apache.ignite.internal.configuration.testframework.ConfigurationExtension;
import org.apache.ignite.internal.configuration.testframework.InjectConfiguration;
import org.apache.ignite.internal.configuration.testframework.InjectRevisionListenerHolder;
-import org.apache.ignite.internal.hlc.HybridClockImpl;
+import org.apache.ignite.internal.hlc.HybridClock;
import org.apache.ignite.internal.index.IndexManager;
import org.apache.ignite.internal.metastorage.MetaStorageManager;
import org.apache.ignite.internal.raft.Loza;
@@ -130,6 +130,9 @@ public class MockedStructuresTest extends IgniteAbstractTest {
@Mock
MetaStorageManager msm;
+ @Mock
+ HybridClock clock;
+
/**
* Revision listener holder. It uses for the test configurations:
* <ul>
@@ -245,10 +248,13 @@ public class MockedStructuresTest extends IgniteAbstractTest {
schemaManager,
dataStorageManager,
tm,
- () -> dataStorageModules.collectSchemasFields(List.of(
- RocksDbDataStorageConfigurationSchema.class,
- TestDataStorageConfigurationSchema.class
- ))
+ () -> dataStorageModules.collectSchemasFields(
+ List.of(
+ RocksDbDataStorageConfigurationSchema.class,
+ TestDataStorageConfigurationSchema.class
+ )
+ ),
+ clock
);
queryProc.start();
@@ -506,7 +512,7 @@ public class MockedStructuresTest extends IgniteAbstractTest {
msm,
schemaManager,
view -> new LocalLogStorageFactory(),
- new HybridClockImpl(),
+ clock,
mock(OutgoingSnapshotsManager.class)
);