You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/05/05 14:33:02 UTC

Review Request 59022: Propagate Component versions and states to Service

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59022/
-----------------------------------------------------------

Review request for Ambari, Dmytro Grinenko, Nate Cole, and Robert Levas.


Bugs: AMBARI-20940
    https://issues.apache.org/jira/browse/AMBARI-20940


Repository: ambari


Description
-------

In order to make it simpler for the UI, the version and repo_state should be propagated to the service level.  Repo_versions should also move to the service, from the component.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java d275eb2 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 67ae5d5 
  ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 2ab69cb 
  ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java 16f724f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceResponse.java e67d124f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java b26814a 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 3f4e7c2 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 9cbcea6 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 3087379 
  ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java e02e422 
  ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 7849463 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 80b4470 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 1f9dc5b 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 4e50153 
  ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java a0d7352 
  ambari-server/src/main/resources/key_properties.json df2006a 
  ambari-server/src/main/resources/properties.json c3b0f68 
  ambari-server/src/test/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnableTest.java 7ba5bc0 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java 8bbd49a 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java f35122a 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 38e6a22 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java 35ce868 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java 8f0a6bb 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java d1705d8 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 9486f9d 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java 04b7933 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java 3039267 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java a814ba8 
  ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java d72f018 
  ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java dfe8f59 
  ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 3a80ca7 


Diff: https://reviews.apache.org/r/59022/diff/1/


Testing
-------

PENDING


Thanks,

Jonathan Hurley

Re: Review Request 59022: Propagate Component versions and states to Service

Posted by Jonathan Hurley <jh...@hortonworks.com>.

> On May 5, 2017, 11 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java
> > Lines 106 (patched)
> > <https://reviews.apache.org/r/59022/diff/1/?file=1709347#file1709347line106>
> >
> >     Maybe make this a float to make rearranging them less cumbersome.

I don't see a lot of repo states being added in the future; I thought it was cleaner to just go ints for this. Do you really think we need to change it?


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59022/#review174025
-----------------------------------------------------------


On May 5, 2017, 10:33 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59022/
> -----------------------------------------------------------
> 
> (Updated May 5, 2017, 10:33 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-20940
>     https://issues.apache.org/jira/browse/AMBARI-20940
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In order to make it simpler for the UI, the version and repo_state should be propagated to the service level.  Repo_versions should also move to the service, from the component.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java d275eb2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 67ae5d5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 2ab69cb 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java 16f724f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceResponse.java e67d124f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java b26814a 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 3f4e7c2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 9cbcea6 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 3087379 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java e02e422 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 7849463 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 80b4470 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 1f9dc5b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 4e50153 
>   ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java a0d7352 
>   ambari-server/src/main/resources/key_properties.json df2006a 
>   ambari-server/src/main/resources/properties.json c3b0f68 
>   ambari-server/src/test/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnableTest.java 7ba5bc0 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java 8bbd49a 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java f35122a 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 38e6a22 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java 35ce868 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java 8f0a6bb 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java d1705d8 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 9486f9d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java 04b7933 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java 3039267 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java a814ba8 
>   ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java d72f018 
>   ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java dfe8f59 
>   ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 3a80ca7 
> 
> 
> Diff: https://reviews.apache.org/r/59022/diff/1/
> 
> 
> Testing
> -------
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 59022: Propagate Component versions and states to Service

Posted by Nate Cole <nc...@hortonworks.com>.

> On May 5, 2017, 11 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java
> > Lines 106 (patched)
> > <https://reviews.apache.org/r/59022/diff/1/?file=1709347#file1709347line106>
> >
> >     Maybe make this a float to make rearranging them less cumbersome.
> 
> Jonathan Hurley wrote:
>     I don't see a lot of repo states being added in the future; I thought it was cleaner to just go ints for this. Do you really think we need to change it?

No, but when we do we'll be cursing it out. :)  Can drop, just wanted to bring it up.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59022/#review174025
-----------------------------------------------------------


On May 5, 2017, 1:55 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59022/
> -----------------------------------------------------------
> 
> (Updated May 5, 2017, 1:55 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-20940
>     https://issues.apache.org/jira/browse/AMBARI-20940
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In order to make it simpler for the UI, the version and repo_state should be propagated to the service level.  Repo_versions should also move to the service, from the component.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java d275eb2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 67ae5d5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 2ab69cb 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java 16f724f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceResponse.java e67d124f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java b26814a 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 3f4e7c2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 9cbcea6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java c747a33 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 3087379 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java e02e422 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 7849463 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 80b4470 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 1f9dc5b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 4e50153 
>   ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java a0d7352 
>   ambari-server/src/main/resources/key_properties.json df2006a 
>   ambari-server/src/main/resources/properties.json c3b0f68 
>   ambari-server/src/test/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnableTest.java 7ba5bc0 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java 8bbd49a 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java f35122a 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 38e6a22 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java 35ce868 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java 8f0a6bb 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java d1705d8 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 9486f9d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java 2e712d1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java 04b7933 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java 3039267 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java a814ba8 
>   ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java d72f018 
>   ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java dfe8f59 
>   ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 3a80ca7 
> 
> 
> Diff: https://reviews.apache.org/r/59022/diff/2/
> 
> 
> Testing
> -------
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 59022: Propagate Component versions and states to Service

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59022/#review174025
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java
Lines 106 (patched)
<https://reviews.apache.org/r/59022/#comment247126>

    Maybe make this a float to make rearranging them less cumbersome.


- Nate Cole


On May 5, 2017, 10:33 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59022/
> -----------------------------------------------------------
> 
> (Updated May 5, 2017, 10:33 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-20940
>     https://issues.apache.org/jira/browse/AMBARI-20940
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In order to make it simpler for the UI, the version and repo_state should be propagated to the service level.  Repo_versions should also move to the service, from the component.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java d275eb2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 67ae5d5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 2ab69cb 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java 16f724f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceResponse.java e67d124f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java b26814a 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 3f4e7c2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 9cbcea6 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 3087379 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java e02e422 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 7849463 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 80b4470 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 1f9dc5b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 4e50153 
>   ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java a0d7352 
>   ambari-server/src/main/resources/key_properties.json df2006a 
>   ambari-server/src/main/resources/properties.json c3b0f68 
>   ambari-server/src/test/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnableTest.java 7ba5bc0 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java 8bbd49a 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java f35122a 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 38e6a22 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java 35ce868 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java 8f0a6bb 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java d1705d8 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 9486f9d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java 04b7933 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java 3039267 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java a814ba8 
>   ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java d72f018 
>   ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java dfe8f59 
>   ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 3a80ca7 
> 
> 
> Diff: https://reviews.apache.org/r/59022/diff/1/
> 
> 
> Testing
> -------
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 59022: Propagate Component versions and states to Service

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59022/#review174072
-----------------------------------------------------------


Ship it!




Ship It!

- Nate Cole


On May 5, 2017, 1:55 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59022/
> -----------------------------------------------------------
> 
> (Updated May 5, 2017, 1:55 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-20940
>     https://issues.apache.org/jira/browse/AMBARI-20940
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In order to make it simpler for the UI, the version and repo_state should be propagated to the service level.  Repo_versions should also move to the service, from the component.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java d275eb2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 67ae5d5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 2ab69cb 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java 16f724f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceResponse.java e67d124f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java b26814a 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 3f4e7c2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 9cbcea6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java c747a33 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 3087379 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java e02e422 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 7849463 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 80b4470 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 1f9dc5b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 4e50153 
>   ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java a0d7352 
>   ambari-server/src/main/resources/key_properties.json df2006a 
>   ambari-server/src/main/resources/properties.json c3b0f68 
>   ambari-server/src/test/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnableTest.java 7ba5bc0 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java 8bbd49a 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java f35122a 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 38e6a22 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java 35ce868 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java 8f0a6bb 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java d1705d8 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 9486f9d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java 2e712d1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java 04b7933 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java 3039267 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java a814ba8 
>   ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java d72f018 
>   ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java dfe8f59 
>   ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 3a80ca7 
> 
> 
> Diff: https://reviews.apache.org/r/59022/diff/2/
> 
> 
> Testing
> -------
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 59022: Propagate Component versions and states to Service

Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59022/#review174118
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Levas


On May 5, 2017, 1:55 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59022/
> -----------------------------------------------------------
> 
> (Updated May 5, 2017, 1:55 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-20940
>     https://issues.apache.org/jira/browse/AMBARI-20940
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In order to make it simpler for the UI, the version and repo_state should be propagated to the service level.  Repo_versions should also move to the service, from the component.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java d275eb2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 67ae5d5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 2ab69cb 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java 16f724f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceResponse.java e67d124f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java b26814a 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 3f4e7c2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 9cbcea6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java c747a33 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 3087379 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java e02e422 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 7849463 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 80b4470 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 1f9dc5b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 4e50153 
>   ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java a0d7352 
>   ambari-server/src/main/resources/key_properties.json df2006a 
>   ambari-server/src/main/resources/properties.json c3b0f68 
>   ambari-server/src/test/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnableTest.java 7ba5bc0 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java 8bbd49a 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java f35122a 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 38e6a22 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java 35ce868 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java 8f0a6bb 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java d1705d8 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 9486f9d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java 2e712d1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java 04b7933 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java 3039267 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java a814ba8 
>   ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java d72f018 
>   ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java dfe8f59 
>   ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 3a80ca7 
> 
> 
> Diff: https://reviews.apache.org/r/59022/diff/2/
> 
> 
> Testing
> -------
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 59022: Propagate Component versions and states to Service

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59022/
-----------------------------------------------------------

(Updated May 5, 2017, 1:55 p.m.)


Review request for Ambari, Dmytro Grinenko, Nate Cole, and Robert Levas.


Changes
-------

Fixed some UT failures


Bugs: AMBARI-20940
    https://issues.apache.org/jira/browse/AMBARI-20940


Repository: ambari


Description
-------

In order to make it simpler for the UI, the version and repo_state should be propagated to the service level.  Repo_versions should also move to the service, from the component.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java d275eb2 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 67ae5d5 
  ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 2ab69cb 
  ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java 16f724f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceResponse.java e67d124f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java b26814a 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 3f4e7c2 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 9cbcea6 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java c747a33 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 3087379 
  ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java e02e422 
  ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 7849463 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 80b4470 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 1f9dc5b 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 4e50153 
  ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java a0d7352 
  ambari-server/src/main/resources/key_properties.json df2006a 
  ambari-server/src/main/resources/properties.json c3b0f68 
  ambari-server/src/test/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnableTest.java 7ba5bc0 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java 8bbd49a 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java f35122a 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 38e6a22 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java 35ce868 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java 8f0a6bb 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java d1705d8 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 9486f9d 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java 2e712d1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java 04b7933 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java 3039267 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java a814ba8 
  ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java d72f018 
  ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java dfe8f59 
  ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 3a80ca7 


Diff: https://reviews.apache.org/r/59022/diff/2/

Changes: https://reviews.apache.org/r/59022/diff/1-2/


Testing
-------

PENDING


Thanks,

Jonathan Hurley