[GitHub] [druid] gianm commented on a change in pull request #10613: expression filter support for vectorized query engines

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #10613:
URL: https://github.com/apache/druid/pull/10613#discussion_r584925952



##########
File path: processing/src/main/java/org/apache/druid/query/dimension/DimensionSpec.java
##########
@@ -70,6 +71,11 @@ default MultiValueDimensionVectorSelector decorate(MultiValueDimensionVectorSele
     throw new UOE("DimensionSpec[%s] cannot vectorize", getClass().getName());
   }
 
+  default VectorObjectSelector decorate(VectorObjectSelector selector)

Review comment:
       > I don't know, the more I think about this, do we really need DimensionSpec, like at all?
   
   I don't think so, because the stuff it does could be done by virtual columns. Removing them would be a big backwards-incompatibility, but we don't necessarily have to remove them; we could just make them not-vectorizable and add notes in the docs that they are a legacy thing.
   
   Today the only DimensionSpec that is vectorizable is DefaultDimensionSpec (the one that does nothing other than pass-through), so nothing special is needed to support it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org