You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/08/05 09:03:43 UTC

[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1206: ORC-1232:[C++] disable the metrics collector at compile phase

dongjoon-hyun commented on code in PR #1206:
URL: https://github.com/apache/orc/pull/1206#discussion_r938609347


##########
c++/src/Utils.hh:
##########
@@ -69,7 +70,10 @@ public:
   AutoStopwatch measure(                                              \
     (METRICS_PTR == nullptr ? nullptr : &METRICS_PTR->LATENCY_VAR),   \
     nullptr, true)
+#else
+#define SCOPED_STOPWATCH(METRICS_PTR, LATENCY_VAR, COUNT_VAR)
+#define SCOPED_MINUS_STOPWATCH(METRICS_PTR, LATENCY_VAR)
+#endif
 
 }
-

Review Comment:
   nit. Shall we recover this irrelevant removal?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org