You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by tamaashu <gi...@git.apache.org> on 2018/10/09 16:07:11 UTC
[GitHub] zookeeper pull request #663: ZOOKEEPER-3154: Update release process to use t...
GitHub user tamaashu opened a pull request:
https://github.com/apache/zookeeper/pull/663
ZOOKEEPER-3154: Update release process to use the MarkDown solution
Added `mvn clean` and `mvn install` to `ant clean` and `ant compile` as dependency.
This way we clean and build zookeeper-docs maven sub-project when we clean and build main ant project.
Added releasenotes.md and fixed small issues in MarkDown files.
Next step is to remove not needed forrest content and dead ant code.
Only valid for branch-3.5, do not backport to branch-3.4.
Change-Id: I308a970c253be1bb82387516bf7b08bd7818a2c7
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tamaashu/zookeeper ZOOKEEPER-3154-3.5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/663.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #663
----
commit 556021f48af1b05647f8506917390c42114c1be7
Author: Tamas Penzes <ta...@...>
Date: 2018-10-09T16:04:46Z
ZOOKEEPER-3154: Update release process to use the MarkDown solution
Added `mvn clean` and `mvn install` to `ant clean` and `ant compile` as dependency.
This way we clean and build zookeeper-docs maven sub-project when we clean and build main ant project.
Added releasenotes.md and fixed small issues in MarkDown files.
Next step is to remove not needed forrest content and dead ant code.
Only valid for master branch, do not backport to branch-3.4 or branch-3.5.
Adopted versions are coming.
Change-Id: I308a970c253be1bb82387516bf7b08bd7818a2c7
----
---
[GitHub] zookeeper issue #663: ZOOKEEPER-3154: Update release process to use the Mark...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/663
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2435/
---
[GitHub] zookeeper issue #663: ZOOKEEPER-3154: Update release process to use the Mark...
Posted by tamaashu <gi...@git.apache.org>.
Github user tamaashu commented on the issue:
https://github.com/apache/zookeeper/pull/663
retest this please
---
[GitHub] zookeeper issue #663: ZOOKEEPER-3154: Update release process to use the Mark...
Posted by tamaashu <gi...@git.apache.org>.
Github user tamaashu commented on the issue:
https://github.com/apache/zookeeper/pull/663
Thanks @lvfangmin and @eolivelli to pointing this out. 2.6.0 was a typo in the master branch (should have been 3.6.0, will fix it in master tomorrow) and got backported here accidentally.
3.5.4 is just a fix for it.
The version number is only added to the pom.xml to be fine, it doesn't change anything during the document generation, but still I would keep the proper version number.
---
[GitHub] zookeeper pull request #663: ZOOKEEPER-3154: Update release process to use t...
Posted by lvfangmin <gi...@git.apache.org>.
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/663#discussion_r223838835
--- Diff: pom.xml ---
@@ -30,7 +30,7 @@
<groupId>org.apache.zookeeper</groupId>
<artifactId>zookeeper</artifactId>
<packaging>pom</packaging>
- <version>2.6.0-SNAPSHOT</version>
+ <version>3.5.5-beta-SNAPSHOT</version>
--- End diff --
Should we move this to a separate PR? Seems it’s not highly related to the Markdown change here.
---
[GitHub] zookeeper pull request #663: ZOOKEEPER-3154: Update release process to use t...
Posted by tamaashu <gi...@git.apache.org>.
Github user tamaashu closed the pull request at:
https://github.com/apache/zookeeper/pull/663
---
[GitHub] zookeeper issue #663: ZOOKEEPER-3154: Update release process to use the Mark...
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/663
Committed to branch-3.5. Thanks @tamaashu !
Please close this PR.
---
[GitHub] zookeeper issue #663: ZOOKEEPER-3154: Update release process to use the Mark...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/663
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2396/
---
[GitHub] zookeeper issue #663: ZOOKEEPER-3154: Update release process to use the Mark...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/663
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2433/
---
[GitHub] zookeeper pull request #663: ZOOKEEPER-3154: Update release process to use t...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/663#discussion_r223854802
--- Diff: pom.xml ---
@@ -30,7 +30,7 @@
<groupId>org.apache.zookeeper</groupId>
<artifactId>zookeeper</artifactId>
<packaging>pom</packaging>
- <version>2.6.0-SNAPSHOT</version>
+ <version>3.5.5-beta-SNAPSHOT</version>
--- End diff --
What is 2.6.0 ?
It doesn't make sense
IMHO it is better to have the same version as the current version
---
[GitHub] zookeeper issue #663: ZOOKEEPER-3154: Update release process to use the Mark...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/663
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2414/
---