[GitHub] [incubator-dolphinscheduler] muzhongjiang commented on pull request #3078: [bugfix] fixed "jackson enum conversion : InvalidFormatException"

[GitBox <gi...@apache.org>]

muzhongjiang commented on pull request #3078:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3078#issuecomment-651134859


   > Hi,
   > You can check this same error issue [1], and which branch of you error.
   > In my opinion, if this error is actually happened in program, we should fix it in front-end but not back-end Jackson serde function, because it should throw exception when deserialize from an empty string enum json string.
   > 
   > 你可以看下 [1] 中的issue，也是同样的问题。你的分支是哪个分支呢？
   > 个人理解，如果这个错误确实存在，我理解我们最好应该在前端向后端传参时就避免这个问题，如果后端在序列化上去处理这个问题的话，可能会导致吞掉一些其他枚举类型在序列化时本应该抛出来的错误。
   > 
   > [1] #3028
   
   
   
   After testing 1.3.0 Release version does not have this problem, dev has this problem.
   This is because the fastjson used in 1.3.0 Release is adapted to the deserialization of enum.
   Now replacing it with jackson should ensure that the function is consistent with the Release version, so the configuration item READ_UNKNOWN_ENUM_VALUES_AS_NULL is opened
   
   经过测试 1.3.0 Release 版本没有这个问题，dev 有这个问题。
   是因为 1.3.0 Release 用的 fastjson，fastjson对 enum 反序列化做了适配。
   现在替换为 jackson 应该保证功能和Release版本一致，所以打开了这个配置项READ_UNKNOWN_ENUM_VALUES_AS_NULL
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org