You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/04/22 11:38:45 UTC

[GitHub] [camel] orpiske opened a new pull request, #7486: RFC CAMEL-17894: stop running impsort and checkstyle by default

orpiske opened a new pull request, #7486:
URL: https://github.com/apache/camel/pull/7486

   Folks, I'd like to hear your opinions about this rather disruptive
   change. 
   
   The motivation for removing those 2 plugins from the default build
   execution is because they are very slow. On my test machine, this
   reduces the build time by between 3 to 4 minutes with "normal Maven"
   (roughly 7.6% improvement). The numbers with Maven Daemon are not so 
   dramatic, but still reduces a bit (varying a lot here, but roughly
   between 20 to 60 seconds). 
   
   The (possible) downside is that this stops the code from automatically
   reformatting the code and sorting the imports by default (ie.: when
   running `mvn -Pfastinstall install`). 
   
   Instead, this introduces a new profile `format` that can be run
   along side the `fastinstall` to do the same. 
   
   Because this can be disruptive to the workflow of others, I'd like to
   hear some thoughts about this.
   
   
   <!-- Uncomment and fill this section if your PR is not trivial
   - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
   - [ ] Each commit in the pull request should have a meaningful subject line and body.
   - [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
   Below are the contribution guidelines:
   https://github.com/apache/camel/blob/main/CONTRIBUTING.md
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] orpiske commented on pull request #7486: CAMEL-17894: stop running impsort and checkstyle by default

Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #7486:
URL: https://github.com/apache/camel/pull/7486#issuecomment-1109413451

   Thanks for the reviews/approvals. Let's merge this and, if there's problems, I'll rollback.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #7486: RFC CAMEL-17894: stop running impsort and checkstyle by default

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7486:
URL: https://github.com/apache/camel/pull/7486#issuecomment-1108388839

   :heavy_check_mark: Finished component verification: 0 component(s) test failed out of **1 component(s) tested**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] orpiske commented on pull request #7486: RFC CAMEL-17894: stop running impsort and checkstyle by default

Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #7486:
URL: https://github.com/apache/camel/pull/7486#issuecomment-1106429861

   I've marked a few folks for some thoughts, but everyone is welcome to give their thoughts. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #7486: RFC CAMEL-17894: stop running impsort and checkstyle by default

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7486:
URL: https://github.com/apache/camel/pull/7486#issuecomment-1108312403

   :heavy_check_mark: Finished component verification: 0 component(s) test failed out of **1 component(s) tested**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] orpiske merged pull request #7486: CAMEL-17894: stop running impsort and checkstyle by default

Posted by GitBox <gi...@apache.org>.
orpiske merged PR #7486:
URL: https://github.com/apache/camel/pull/7486


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] orpiske commented on pull request #7486: CAMEL-17894: stop running impsort and checkstyle by default

Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #7486:
URL: https://github.com/apache/camel/pull/7486#issuecomment-1109465114

   > Something is not looking OK in some cases 😩. I am looking at it.
   
   Fixed. https://github.com/apache/camel/commit/8b18abb2db30b0484c4d576e91c2009dadb05a6f


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] orpiske commented on pull request #7486: RFC CAMEL-17894: stop running impsort and checkstyle by default

Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #7486:
URL: https://github.com/apache/camel/pull/7486#issuecomment-1106444886

   > 
   
   Thanks. Yeah, I think that would be a cool idea to work-around any leftovers!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #7486: CAMEL-17894: stop running impsort and checkstyle by default

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7486:
URL: https://github.com/apache/camel/pull/7486#issuecomment-1108726260

   :heavy_check_mark: Finished component verification: 0 component(s) test failed out of **1 component(s) tested**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #7486: RFC CAMEL-17894: stop running impsort and checkstyle by default

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7486:
URL: https://github.com/apache/camel/pull/7486#issuecomment-1106474105

   :no_entry_sign: There are (likely) no components to be tested in this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] orpiske commented on pull request #7486: CAMEL-17894: stop running impsort and checkstyle by default

Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #7486:
URL: https://github.com/apache/camel/pull/7486#issuecomment-1108664175

   I am marking this one as ready for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] orpiske commented on pull request #7486: CAMEL-17894: stop running impsort and checkstyle by default

Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #7486:
URL: https://github.com/apache/camel/pull/7486#issuecomment-1109438580

   Something is not looking OK in some cases 😩. I am looking at it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org