You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/08/31 08:14:15 UTC
[GitHub] [apisix] gy09535 commented on a change in pull request #2121: fix: limit count config not effective
gy09535 commented on a change in pull request #2121:
URL: https://github.com/apache/apisix/pull/2121#discussion_r479969372
##########
File path: apisix/plugin.lua
##########
@@ -297,6 +297,7 @@ local function merge_service_route(service_conf, route_conf)
local new_conf = core.table.deepcopy(service_conf)
new_conf.value.service_id = new_conf.value.id
new_conf.value.id = route_conf.value.id
+ new_conf.modifiedIndex = route_conf.modifiedIndex
Review comment:
the "modifiedIndex" while be used in other space as route modified Index, if I change this key ,should change in all place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org